Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: tools/run-tests.py

Issue 1098883002: [test-runner] Add dedicated test mode for tryserver. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index f7e77ca1543a1ab67c15c4fe4b90d58cf5737a57..70fc98f142ca25866a69810c46bd504ccf247274 100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -112,8 +112,18 @@ MODES = {
"execution_mode": "release",
"output_folder": "release",
},
- # This mode requires v8 to be compiled with dchecks and slow dchecks.
+ # Normal trybot release configuraion. There, dchecks are always on which
Jakob Kummerow 2015/04/20 15:26:02 nit: configuration
Michael Achenbach 2015/04/21 07:45:22 Done.
+ # implies debug is set. Hence, the status file needs to assume debug-like
+ # behavior/timeouts.
"tryrelease": {
+ "flags": RELEASE_FLAGS,
+ "timeout_scalefactor": 1,
Jakob Kummerow 2015/04/20 15:26:02 Contrary to the expectation set by the comment abo
Michael Achenbach 2015/04/21 07:45:22 Yes. It should make a difference to the slow versi
+ "status_mode": "debug",
+ "execution_mode": "release",
+ "output_folder": "release",
+ },
+ # This mode requires v8 to be compiled with dchecks and slow dchecks.
Michael Achenbach 2015/04/20 13:22:33 This has not been used yet.
+ "slowrelease": {
"flags": RELEASE_FLAGS + ["--enable-slow-asserts"],
"timeout_scalefactor": 2,
"status_mode": "debug",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698