Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1098883002: [test-runner] Add dedicated test mode for tryserver. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test-runner] Add dedicated test mode for tryserver. BUG= Committed: https://crrev.com/c15ca44b0c15ecf24d09a828711c24c197287860 Cr-Commit-Position: refs/heads/master@{#27952}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M tools/run-tests.py View 1 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1098883002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/1098883002/diff/1/tools/run-tests.py#newcode125 tools/run-tests.py:125: # This mode requires v8 to be compiled ...
5 years, 8 months ago (2015-04-20 13:22:33 UTC) #2
Jakob Kummerow
LGTM with comments https://codereview.chromium.org/1098883002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/1098883002/diff/1/tools/run-tests.py#newcode115 tools/run-tests.py:115: # Normal trybot release configuraion. There, ...
5 years, 8 months ago (2015-04-20 15:26:02 UTC) #3
Michael Achenbach
https://codereview.chromium.org/1098883002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/1098883002/diff/1/tools/run-tests.py#newcode115 tools/run-tests.py:115: # Normal trybot release configuraion. There, dchecks are always ...
5 years, 8 months ago (2015-04-21 07:45:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098883002/20001
5 years, 8 months ago (2015-04-21 07:45:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 08:17:24 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 08:17:32 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c15ca44b0c15ecf24d09a828711c24c197287860
Cr-Commit-Position: refs/heads/master@{#27952}

Powered by Google App Engine
This is Rietveld 408576698