 Chromium Code Reviews
 Chromium Code Reviews Issue 1098863003:
  Import Reversed adapter from Chromium and use it in v8.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 1098863003:
  Import Reversed adapter from Chromium and use it in v8.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| Index: src/compiler/arm/instruction-selector-arm.cc | 
| diff --git a/src/compiler/arm/instruction-selector-arm.cc b/src/compiler/arm/instruction-selector-arm.cc | 
| index f0040474f4a6ae416d08c1615fbf8e8aee2e8c26..cfe7f55e4dcc1ab8f244bca9dd872e775c63b0cb 100644 | 
| --- a/src/compiler/arm/instruction-selector-arm.cc | 
| +++ b/src/compiler/arm/instruction-selector-arm.cc | 
| @@ -2,6 +2,7 @@ | 
| // Use of this source code is governed by a BSD-style license that can be | 
| // found in the LICENSE file. | 
| +#include "src/base/adapters.h" | 
| #include "src/base/bits.h" | 
| #include "src/compiler/instruction-selector-impl.h" | 
| #include "src/compiler/node-matchers.h" | 
| @@ -1099,9 +1100,8 @@ void InstructionSelector::VisitCall(Node* node, BasicBlock* handler) { | 
| // TODO(dcarney): might be possible to use claim/poke instead | 
| // Push any stack arguments. | 
| - for (auto i = buffer.pushed_nodes.rbegin(); i != buffer.pushed_nodes.rend(); | 
| - ++i) { | 
| - Emit(kArmPush, g.NoOutput(), g.UseRegister(*i)); | 
| + for (auto i : base::Reversed(buffer.pushed_nodes)) { | 
| 
Michael Starzinger
2015/04/20 13:11:14
nit: s/auto i/Node* node/
 
Sven Panne
2015/04/20 14:38:35
Done.
 | 
| + Emit(kArmPush, g.NoOutput(), g.UseRegister(i)); | 
| } | 
| // Pass label of exception handler block. |