Import Reversed adapter from Chromium and use it in v8.

Import Reversed adapter from Chromium and use it in v8.

Committed: https://crrev.com/314e73d1ec93de843e9140f487159642fac66ede
Cr-Commit-Position: refs/heads/master@{#27947}

[Sven Panne, 2015-04-20 12:44:28]

svenpanne@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2015-04-20 13:11:14]

LGTM. Only nits.

https://codereview.chromium.org/1098863003/diff/1/src/compiler/arm/instructio...
File src/compiler/arm/instruction-selector-arm.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/arm/instructio...
src/compiler/arm/instruction-selector-arm.cc:1103: for (auto i :
base::Reversed(buffer.pushed_nodes)) {
nit: s/auto i/Node* node/

https://codereview.chromium.org/1098863003/diff/1/src/compiler/ia32/instructi...
File src/compiler/ia32/instruction-selector-ia32.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/ia32/instructi...
src/compiler/ia32/instruction-selector-ia32.cc:835: for (auto i :
base::Reversed(buffer.pushed_nodes)) {
nit: s/auto i/Node* node/

https://codereview.chromium.org/1098863003/diff/1/src/compiler/mips/instructi...
File src/compiler/mips/instruction-selector-mips.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/mips/instructi...
src/compiler/mips/instruction-selector-mips.cc:523: for (auto i :
base::Reversed(buffer.pushed_nodes)) {
nit: s/auto i/Node* node/

https://codereview.chromium.org/1098863003/diff/1/src/compiler/mips64/instruc...
File src/compiler/mips64/instruction-selector-mips64.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/mips64/instruc...
src/compiler/mips64/instruction-selector-mips64.cc:672: for (auto i :
base::Reversed(buffer.pushed_nodes)) {
nit: s/auto i/Node* node/

https://codereview.chromium.org/1098863003/diff/1/src/compiler/ppc/instructio...
File src/compiler/ppc/instruction-selector-ppc.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/ppc/instructio...
src/compiler/ppc/instruction-selector-ppc.cc:1457: for (auto i :
base::Reversed(buffer.pushed_nodes)) {
nit: s/auto i/Node* node/

https://codereview.chromium.org/1098863003/diff/1/src/compiler/register-alloc...
File src/compiler/register-allocator.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/register-alloc...
src/compiler/register-allocator.cc:1415: for (auto i :
base::Reversed(code()->instruction_blocks())) {
nit: s/auto i/Node* node/

https://codereview.chromium.org/1098863003/diff/1/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/scheduler.cc#n...
src/compiler/scheduler.cc:1626: for (auto i : base::Reversed(nodes)) {
nit: s/auto i/Node* node/

https://codereview.chromium.org/1098863003/diff/1/src/compiler/x64/instructio...
File src/compiler/x64/instruction-selector-x64.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/x64/instructio...
src/compiler/x64/instruction-selector-x64.cc:1038: for (auto i :
base::Reversed(buffer.pushed_nodes)) {
nit: s/auto i/Node* node/

[Sven Panne, 2015-04-20 14:38:35]

Feedback addressed, landing...

https://codereview.chromium.org/1098863003/diff/1/src/compiler/arm/instructio...
File src/compiler/arm/instruction-selector-arm.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/arm/instructio...
src/compiler/arm/instruction-selector-arm.cc:1103: for (auto i :
base::Reversed(buffer.pushed_nodes)) {
On 2015/04/20 13:11:14, Michael Starzinger wrote:
> nit: s/auto i/Node* node/

Done.

https://codereview.chromium.org/1098863003/diff/1/src/compiler/ia32/instructi...
File src/compiler/ia32/instruction-selector-ia32.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/ia32/instructi...
src/compiler/ia32/instruction-selector-ia32.cc:835: for (auto i :
base::Reversed(buffer.pushed_nodes)) {
On 2015/04/20 13:11:14, Michael Starzinger wrote:
> nit: s/auto i/Node* node/

Done.

https://codereview.chromium.org/1098863003/diff/1/src/compiler/mips/instructi...
File src/compiler/mips/instruction-selector-mips.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/mips/instructi...
src/compiler/mips/instruction-selector-mips.cc:523: for (auto i :
base::Reversed(buffer.pushed_nodes)) {
On 2015/04/20 13:11:14, Michael Starzinger wrote:
> nit: s/auto i/Node* node/

Done.

https://codereview.chromium.org/1098863003/diff/1/src/compiler/mips64/instruc...
File src/compiler/mips64/instruction-selector-mips64.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/mips64/instruc...
src/compiler/mips64/instruction-selector-mips64.cc:672: for (auto i :
base::Reversed(buffer.pushed_nodes)) {
On 2015/04/20 13:11:14, Michael Starzinger wrote:
> nit: s/auto i/Node* node/

Done.

https://codereview.chromium.org/1098863003/diff/1/src/compiler/ppc/instructio...
File src/compiler/ppc/instruction-selector-ppc.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/ppc/instructio...
src/compiler/ppc/instruction-selector-ppc.cc:1457: for (auto i :
base::Reversed(buffer.pushed_nodes)) {
On 2015/04/20 13:11:14, Michael Starzinger wrote:
> nit: s/auto i/Node* node/

Done.

https://codereview.chromium.org/1098863003/diff/1/src/compiler/register-alloc...
File src/compiler/register-allocator.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/register-alloc...
src/compiler/register-allocator.cc:1415: for (auto i :
base::Reversed(code()->instruction_blocks())) {
On 2015/04/20 13:11:14, Michael Starzinger wrote:
> nit: s/auto i/Node* node/

I guess you mean "Instruction* block" here. :-) Done.

https://codereview.chromium.org/1098863003/diff/1/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/scheduler.cc#n...
src/compiler/scheduler.cc:1626: for (auto i : base::Reversed(nodes)) {
On 2015/04/20 13:11:14, Michael Starzinger wrote:
> nit: s/auto i/Node* node/

Done.

https://codereview.chromium.org/1098863003/diff/1/src/compiler/x64/instructio...
File src/compiler/x64/instruction-selector-x64.cc (right):

https://codereview.chromium.org/1098863003/diff/1/src/compiler/x64/instructio...
src/compiler/x64/instruction-selector-x64.cc:1038: for (auto i :
base::Reversed(buffer.pushed_nodes)) {
On 2015/04/20 13:11:14, Michael Starzinger wrote:
> nit: s/auto i/Node* node/

Done.

[Sven Panne, 2015-04-20 14:39:04]

The CQ bit was checked by svenpanne@chromium.org

[Sven Panne, 2015-04-20 14:39:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1098863003/#ps20001
(title: "Addressed feedback. Rebased.")

[commit-bot: I haz the power, 2015-04-20 14:39:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1098863003/20001

[commit-bot: I haz the power, 2015-04-20 16:24:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-20 16:25:10]

Patchset 2 (id:??) landed as
https://crrev.com/314e73d1ec93de843e9140f487159642fac66ede
Cr-Commit-Position: refs/heads/master@{#27947}