Omnibox - Do Not Allow HTTP/HTTPS Equivalence if User Explicitly Entered A Scheme

chrome/browser/autocomplete/shortcuts_provider.h

Index: chrome/browser/autocomplete/shortcuts_provider.h
diff --git a/chrome/browser/autocomplete/shortcuts_provider.h b/chrome/browser/autocomplete/shortcuts_provider.h
index af314a070d43014e580a4b4d0e0bd7cec9bcf3ec..1d1cb0b18c25c5fd8d95ee654959d81906725469 100644
--- a/chrome/browser/autocomplete/shortcuts_provider.h
+++ b/chrome/browser/autocomplete/shortcuts_provider.h
@@ -52,13 +52,14 @@ class ShortcutsProvider
   // Returns an AutocompleteMatch corresponding to |shortcut|. Assigns it
   // |relevance| score in the process, and highlights the description and
   // contents against |input|, which should be the lower-cased version of
-  // the user's input. |input| and |fixed_up_input_text| are used to decide
-  // what can be inlined.
+  // the user's input. |input|, |fixed_up_input_text|, and |words|  are used

[Peter Kasting, 2015/06/06 01:31:23]

Nit: Extra space

[Mark P, 2015/06/09 19:29:38]

Now obsolete.

+  // to decide what can be inlined.

[Peter Kasting, 2015/06/06 01:31:23]

Nit: You might want to just give one sentence on how these things are used or
what the overall inlineability goal is supposed to be.

[Mark P, 2015/06/09 19:29:38]

Now (mostly) obsolete, or at least not relevant to this changelist.

   AutocompleteMatch ShortcutToACMatch(
       const ShortcutsDatabase::Shortcut& shortcut,
       int relevance,
       const AutocompleteInput& input,
-      const base::string16& fixed_up_input_text);
+      const base::string16& fixed_up_input_text,
+      const std::vector<base::string16>& words);

[Peter Kasting, 2015/06/06 01:31:23]

Nit: I kinda feel like ComputeStrippedDestinationURL() should define a typedef
for this if it wants other people using this type, and we should use that here
and elsewhere.

[Mark P, 2015/06/09 19:29:38]

Now obsolete.

 
   // Returns a map mapping characters to groups of words from |text| that start
   // with those characters, ordered lexicographically descending so that longer