chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc - Issue 1098843004: Omnibox - Do Not Allow HTTP/HTTPS Equivalence if User Explicitly Entered A Scheme

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

Issue 1098843004: Omnibox - Do Not Allow HTTP/HTTPS Equivalence if User Explicitly Entered A Scheme (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix browsertests compile error (sigh) Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

index af5bb961e9be1eea28c077f642a16337c08f6eae..29f29cab6e8f0e8cb8143d3dfd459854422756fd 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

@@ -314,6 +314,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, CloseOmniboxPopupOnTextDrag) {

results.AppendMatches(AutocompleteInput(), matches);

results.SortAndCull(

AutocompleteInput(),

+ std::string(),

TemplateURLServiceFactory::GetForProfile(browser()->profile()));

// The omnibox popup should open with suggestions displayed.

« no previous file with comments | « chrome/browser/autocomplete/search_provider_unittest.cc ('k') | components/omnibox/autocomplete_controller.cc » ('j') | no next file with comments »