chrome/browser/autocomplete/history_url_provider_unittest.cc - Issue 1098843004: Omnibox - Do Not Allow HTTP/HTTPS Equivalence if User Explicitly Entered A Scheme

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/history_url_provider_unittest.cc

Issue 1098843004: Omnibox - Do Not Allow HTTP/HTTPS Equivalence if User Explicitly Entered A Scheme (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: possible fix for mac code (cannot compile mac code myself) Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/autocomplete_provider_unittest.cc ('K') | « chrome/browser/autocomplete/autocomplete_provider_unittest.cc ('k') | chrome/browser/autocomplete/search_provider_unittest.cc » ('j') | chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/history_url_provider_unittest.cc

diff --git a/chrome/browser/autocomplete/history_url_provider_unittest.cc b/chrome/browser/autocomplete/history_url_provider_unittest.cc

index 6a3edeef501d256e70e24c7d54ac3f2579561880..32982ad86e0665312d6c034b6c20b42d11c27aac 100644

--- a/chrome/browser/autocomplete/history_url_provider_unittest.cc

+++ b/chrome/browser/autocomplete/history_url_provider_unittest.cc

@@ -321,8 +321,10 @@ void HistoryURLProviderTest::RunTest(

if (sort_matches_) {

TemplateURLService* service =

TemplateURLServiceFactory::GetForProfile(profile_.get());

- for (ACMatches::iterator i = matches_.begin(); i != matches_.end(); ++i)

- i->ComputeStrippedDestinationURL(service);

+ for (ACMatches::iterator i = matches_.begin(); i != matches_.end(); ++i) {

+ i->ComputeStrippedDestinationURL(

+ input, client_.get()->GetAcceptLanguages(), service);

Peter Kasting 2015/06/29 05:04:58 No need for .get() when doing ->.

Mark P 2015/06/30 04:23:16 Done.

+ }

AutocompleteResult::DedupMatchesByDestination(

input.current_page_classification(), false, &matches_);

std::sort(matches_.begin(), matches_.end(),