chrome/browser/autocomplete/autocomplete_controller.cc - Issue 1098843004: Omnibox - Do Not Allow HTTP/HTTPS Equivalence if User Explicitly Entered A Scheme

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/autocomplete_controller.cc

Issue 1098843004: Omnibox - Do Not Allow HTTP/HTTPS Equivalence if User Explicitly Entered A Scheme (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: possible fix for mac code (cannot compile mac code myself) Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_provider_unittest.cc » ('j') | chrome/browser/autocomplete/autocomplete_provider_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/autocomplete_controller.cc

diff --git a/chrome/browser/autocomplete/autocomplete_controller.cc b/chrome/browser/autocomplete/autocomplete_controller.cc

index bd551edc8ff6c5f41ed6e4e234bb38ecdf2038c7..595d7c4f43dc21421a18f053ba74db955c6d0f38 100644

--- a/chrome/browser/autocomplete/autocomplete_controller.cc

+++ b/chrome/browser/autocomplete/autocomplete_controller.cc

@@ -170,6 +170,7 @@ AutocompleteController::AutocompleteController(

keyword_provider_(NULL),

search_provider_(NULL),

zero_suggest_provider_(NULL),

+ result_(provider_client_.get()),

stop_timer_duration_(OmniboxFieldTrial::StopTimerFieldTrialDuration()),

done_(true),

in_start_(false),

@@ -399,7 +400,7 @@ void AutocompleteController::UpdateResult(

if (regenerate_result)

result_.Reset();

- AutocompleteResult last_result;

+ AutocompleteResult last_result(provider_client_.get());

last_result.Swap(&result_);

for (Providers::const_iterator i(providers_.begin());