Omnibox - Do Not Allow HTTP/HTTPS Equivalence if User Explicitly Entered A Scheme

components/omnibox/autocomplete_result_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/autocomplete_result.h"
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/field_trial.h"
@@ skipping 187 matching lines @@
     const TestData* expected, size_t expected_size) {
   AutocompleteInput input(base::ASCIIToUTF16("a"), base::string16::npos,
                           std::string(), GURL(),
                           OmniboxEventProto::INVALID_SPEC, false, false, false,
                           true, false, TestSchemeClassifier());
 
   ACMatches last_matches;
   PopulateAutocompleteMatches(last, last_size, &last_matches);
   AutocompleteResult last_result;
   last_result.AppendMatches(input, last_matches);
-  last_result.SortAndCull(input, template_url_service_.get());
+  last_result.SortAndCull(input, std::string(), template_url_service_.get());
 
   ACMatches current_matches;
   PopulateAutocompleteMatches(current, current_size, &current_matches);
   AutocompleteResult current_result;
   current_result.AppendMatches(input, current_matches);
-  current_result.SortAndCull(input, template_url_service_.get());
+  current_result.SortAndCull(input, std::string(), template_url_service_.get());
   current_result.CopyOldMatches(
-      input, last_result, template_url_service_.get());
+      input, std::string(), last_result, template_url_service_.get());
 
   AssertResultMatches(current_result, expected, expected_size);
 }
 
 // Assertion testing for AutocompleteResult::Swap.
 TEST_F(AutocompleteResultTest, Swap) {
   AutocompleteResult r1;
   AutocompleteResult r2;
 
   // Swap with empty shouldn't do anything interesting.
   r1.Swap(&r2);
   EXPECT_EQ(r1.end(), r1.default_match());
   EXPECT_EQ(r2.end(), r2.default_match());
 
   // Swap with a single match.
   ACMatches matches;
   AutocompleteMatch match;
   match.relevance = 1;
   match.allowed_to_be_default_match = true;
   AutocompleteInput input(base::ASCIIToUTF16("a"), base::string16::npos,
                           std::string(), GURL(),
                           OmniboxEventProto::INVALID_SPEC, false, false, false,
                           true, false, TestSchemeClassifier());
   matches.push_back(match);
   r1.AppendMatches(input, matches);
-  r1.SortAndCull(input, template_url_service_.get());
+  r1.SortAndCull(input, std::string(), template_url_service_.get());
   EXPECT_EQ(r1.begin(), r1.default_match());
   EXPECT_EQ("http://a/", r1.alternate_nav_url().spec());
   r1.Swap(&r2);
   EXPECT_TRUE(r1.empty());
   EXPECT_EQ(r1.end(), r1.default_match());
   EXPECT_TRUE(r1.alternate_nav_url().is_empty());
   ASSERT_FALSE(r2.empty());
   EXPECT_EQ(r2.begin(), r2.default_match());
   EXPECT_EQ("http://a/", r2.alternate_nav_url().spec());
 }
@@ skipping 116 matching lines @@
   PopulateAutocompleteMatches(data, arraysize(data), &matches);
   matches[1].destination_url = GURL();
   matches[3].destination_url = GURL();
   matches[4].destination_url = GURL();
 
   AutocompleteInput input(base::string16(), base::string16::npos, std::string(),
                           GURL(), OmniboxEventProto::INVALID_SPEC, false, false,
                           false, true, false, TestSchemeClassifier());
   AutocompleteResult result;
   result.AppendMatches(input, matches);
-  result.SortAndCull(input, template_url_service_.get());
+  result.SortAndCull(input, std::string(), template_url_service_.get());
 
   // Of the two results with the same non-empty destination URL, the
   // lower-relevance one should be dropped.  All of the results with empty URLs
   // should be kept.
   ASSERT_EQ(4U, result.size());
   EXPECT_TRUE(result.match_at(0)->destination_url.is_empty());
   EXPECT_EQ(1300, result.match_at(0)->relevance);
   EXPECT_TRUE(result.match_at(1)->destination_url.is_empty());
   EXPECT_EQ(1200, result.match_at(1)->relevance);
   EXPECT_TRUE(result.match_at(2)->destination_url.is_empty());
@@ skipping 24 matching lines @@
   matches[1].destination_url = GURL("http://www.foo.com/s?q=foo2");
   matches[2].destination_url = GURL("http://www.foo.com/s?q=foo&oq=f");
   matches[3].destination_url = GURL("http://www.foo.com/s?q=foo&aqs=0");
   matches[4].destination_url = GURL("http://www.foo.com/");
 
   AutocompleteInput input(base::string16(), base::string16::npos, std::string(),
                           GURL(), OmniboxEventProto::INVALID_SPEC, false, false,
                           false, true, false, TestSchemeClassifier());
   AutocompleteResult result;
   result.AppendMatches(input, matches);
-  result.SortAndCull(input, template_url_service_.get());
+  result.SortAndCull(input, std::string(), template_url_service_.get());
 
   // We expect the 3rd and 4th results to be removed.
   ASSERT_EQ(3U, result.size());
   EXPECT_EQ("http://www.foo.com/s?q=foo",
             result.match_at(0)->destination_url.spec());
   EXPECT_EQ(1300, result.match_at(0)->relevance);
   EXPECT_EQ("http://www.foo.com/s?q=foo2",
             result.match_at(1)->destination_url.spec());
   EXPECT_EQ(1200, result.match_at(1)->relevance);
   EXPECT_EQ("http://www.foo.com/",
@@ skipping 30 matching lines @@
   matches[2].destination_url = GURL("http://www.foo.com/s?q=foo&oq=f");
   matches[3].destination_url = GURL("http://www.foo.com/s?q=foo&aqs=0");
   matches[4].destination_url = GURL("http://www.foo.com/");
   matches[5].destination_url = GURL("http://www.foo.com/s?q=foo2&oq=f");
 
   AutocompleteInput input(base::string16(), base::string16::npos, std::string(),
                           GURL(), OmniboxEventProto::INVALID_SPEC, false, false,
                           false, true, false, TestSchemeClassifier());
   AutocompleteResult result;
   result.AppendMatches(input, matches);
-  result.SortAndCull(input, template_url_service_.get());
+  result.SortAndCull(input, std::string(), template_url_service_.get());
 
   // Expect 3 unique results after SortAndCull().
   ASSERT_EQ(3U, result.size());
 
   // Check that 3rd and 4th result got added to the first result as dups
   // and also duplicates of the 4th match got copied.
   ASSERT_EQ(4U, result.match_at(0)->duplicate_matches.size());
   const AutocompleteMatch* first_match = result.match_at(0);
   EXPECT_EQ(matches[2].destination_url,
             first_match->duplicate_matches.at(1).destination_url);
@@ skipping 32 matching lines @@
         OmniboxFieldTrial::kBundledExperimentFieldTrialName, "A", params));
   }
   base::FieldTrialList::CreateFieldTrial(
       OmniboxFieldTrial::kBundledExperimentFieldTrialName, "A");
 
   AutocompleteInput input(base::string16(), base::string16::npos, std::string(),
                           GURL(), OmniboxEventProto::HOME_PAGE, false, false,
                           false, true, false, TestSchemeClassifier());
   AutocompleteResult result;
   result.AppendMatches(input, matches);
-  result.SortAndCull(input, template_url_service_.get());
+  result.SortAndCull(input, std::string(), template_url_service_.get());
 
   // Check the new ordering.  The history-title results should be omitted.
   // We cannot check relevance scores because the matches are sorted by
   // demoted relevance but the actual relevance scores are not modified.
   ASSERT_EQ(3u, result.size());
   EXPECT_EQ("http://search-what-you-typed/",
             result.match_at(0)->destination_url.spec());
   EXPECT_EQ("http://history-url/",
             result.match_at(1)->destination_url.spec());
   EXPECT_EQ("http://search-history/",
@@ skipping 24 matching lines @@
   base::FieldTrialList::CreateFieldTrial(
       OmniboxFieldTrial::kBundledExperimentFieldTrialName, "C");
 
   {
     AutocompleteInput input(
         base::string16(), base::string16::npos, std::string(), GURL(),
         OmniboxEventProto::INSTANT_NTP_WITH_FAKEBOX_AS_STARTING_FOCUS, false,
         false, false, true, false, TestSchemeClassifier());
     AutocompleteResult result;
     result.AppendMatches(input, matches);
-    result.SortAndCull(input, template_url_service_.get());
+    result.SortAndCull(input, std::string(), template_url_service_.get());
 
     // The NAVSUGGEST dup-url stay above search-url since the navsuggest
     // variant should not be demoted.
     ASSERT_EQ(4u, result.size());
     EXPECT_EQ("http://search-what-you-typed/",
               result.match_at(0)->destination_url.spec());
     EXPECT_EQ("http://dup-url/",
               result.match_at(1)->destination_url.spec());
     EXPECT_EQ(AutocompleteMatchType::NAVSUGGEST,
               result.match_at(1)->type);
@@ skipping 17 matching lines @@
     // is already a legal default match (which is the default from
     // PopulateAutocompleteMatches()).
     ACMatches matches;
     PopulateAutocompleteMatches(data, arraysize(data), &matches);
     AutocompleteInput input(base::string16(), base::string16::npos,
                             std::string(), GURL(), OmniboxEventProto::HOME_PAGE,
                             false, false, false, true, false,
                             TestSchemeClassifier());
     AutocompleteResult result;
     result.AppendMatches(input, matches);
-    result.SortAndCull(input, template_url_service_.get());
+    result.SortAndCull(input, std::string(), template_url_service_.get());
     AssertResultMatches(result, data, 4);
   }
 
   {
     // Check that reorder swaps up a result appropriately.
     ACMatches matches;
     PopulateAutocompleteMatches(data, arraysize(data), &matches);
     matches[0].allowed_to_be_default_match = false;
     matches[1].allowed_to_be_default_match = false;
     AutocompleteInput input(base::string16(), base::string16::npos,
                             std::string(), GURL(), OmniboxEventProto::HOME_PAGE,
                             false, false, false, true, false,
                             TestSchemeClassifier());
     AutocompleteResult result;
     result.AppendMatches(input, matches);
-    result.SortAndCull(input, template_url_service_.get());
+    result.SortAndCull(input, std::string(), template_url_service_.get());
     ASSERT_EQ(4U, result.size());
     EXPECT_EQ("http://c/", result.match_at(0)->destination_url.spec());
     EXPECT_EQ("http://a/", result.match_at(1)->destination_url.spec());
     EXPECT_EQ("http://b/", result.match_at(2)->destination_url.spec());
     EXPECT_EQ("http://d/", result.match_at(3)->destination_url.spec());
   }
 }
 
 TEST_F(AutocompleteResultTest, TopMatchIsStandaloneVerbatimMatch) {
   ACMatches matches;
@@ skipping 18 matching lines @@
   matches.clear();
 
   // Case 4: Standalone verbatim match found in AutocompleteResult.
   PopulateAutocompleteMatchesFromTestData(kVerbatimMatches, 1, &matches);
   PopulateAutocompleteMatchesFromTestData(kNonVerbatimMatches, 1, &matches);
   result.AppendMatches(AutocompleteInput(), matches);
   EXPECT_TRUE(result.TopMatchIsStandaloneVerbatimMatch());
   result.Reset();
   matches.clear();
 }