Omnibox - Do Not Allow HTTP/HTTPS Equivalence if User Explicitly Entered A Scheme

components/omnibox/autocomplete_match_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/autocomplete_match.h"
 
 #include "base/basictypes.h"
+#include "base/strings/utf_string_conversions.h"
+#include "components/omnibox/test_scheme_classifier.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 TEST(AutocompleteMatchTest, MoreRelevant) {
   struct RelevantCases {
     int r1;
     int r2;
     bool expected_result;
   } cases[] = {
     {  10,   0, true  },
     {  10,  -5, true  },
@@ skipping 102 matching lines @@
       NULL, 0, false, AutocompleteMatchType::URL_WHAT_YOU_TYPED));
   m.duplicate_matches.push_back(AutocompleteMatch(
       NULL, 0, false, AutocompleteMatchType::URL_WHAT_YOU_TYPED));
   EXPECT_FALSE(m.SupportsDeletion());
 
   // A non-deletable match, with at least one deletable duplicate.
   m.duplicate_matches.push_back(AutocompleteMatch(
       NULL, 0, true, AutocompleteMatchType::URL_WHAT_YOU_TYPED));
   EXPECT_TRUE(m.SupportsDeletion());
 }
+
+TEST(AutocompleteMatchTest, Duplicates) {
+  struct DuplicateCases {
+    const wchar_t* input;
+    const std::string url1;
+    const std::string url2;
+    const bool expected_duplicate;
+  } cases[] = {
+    { L"g", "http://www.google.com/",  "https://www.google.com/",    true },
+    { L"g", "http://www.google.com/",  "http://www.google.com",      true },
+    { L"g", "http://google.com/",      "http://www.google.com/",     true },
+    { L"g", "http://www.google.com/",  "HTTP://www.GOOGLE.com/",     true },
+    { L"g", "http://www.google.com/1", "http://www.google.com/1/",   true },
+    { L"g", "http://www.google.com/",  "http://www.google.com",      true },
+    { L"g", "https://www.google.com/", "http://google.com",          true },
+    { L"g", "http://www.google.com/",  "wss://www.google.com/",      false },
+    { L"g", "http://www.google.com/",  "http://www.google.com/1",    false },
+    { L"g", "http://www.google.com/",  "http://www.goo.com/",        false },
+    { L"g", "http://www.google.com/",  "http://w2.google.com/",      false },
+    { L"g", "http://www.google.com/",  "http://m.google.com/",       false },
+    { L"g", "http://www.google.com/",  "http://www.google.com/?foo", false },
+
+    // Some tests to verify that, depending on the user's input, we don't
+    // allow URL with different schemes to be considered duplicates.
+    { L"http://g", "http://google.com/",
+                   "https://google.com/",  false },
+    { L"http://g", "http://blah.com/",
+                   "https://blah.com/",    true  },
+    { L"http://g", "http://google.com/1",
+                   "https://google.com/1", false },
+    { L"http://g hello",    "http://google.com/",
+                            "https://google.com/", false },
+    { L"hello http://g",    "http://google.com/",
+                            "https://google.com/", false },
+    { L"hello http://g",    "http://blah.com/",
+                            "https://blah.com/",   true  },
+    { L"http://b http://g", "http://google.com/",
+                            "https://google.com/", false },
+    { L"http://b http://g", "http://blah.com/",
+                            "https://blah.com/",   false },
+
+    // A simple test to verify that if the user types unicode that matches
+    // the beginning of a punycode-encoded hostname then we consider that
+    // a match.

[Peter Kasting, 2015/06/29 05:04:59]

Nit: For both of the comments here, you could shorten constructions like "A test
to verify that for X, we Y" to just "For X, we should Y" or similar.

[Mark P, 2015/06/30 04:23:17]

Done.

+    { L"x",               "http://xn--1lq90ic7f1rc.cn/",
+                          "https://xn--1lq90ic7f1rc.cn/", true  },
+    { L"http://\x5317 x", "http://xn--1lq90ic7f1rc.cn/",
+                          "https://xn--1lq90ic7f1rc.cn/", false },
+    { L"http://\x89c6 x", "http://xn--1lq90ic7f1rc.cn/",
+                          "https://xn--1lq90ic7f1rc.cn/", true  },
+    { L"http://x",        "http://xn--1lq90ic7f1rc.cn/",
+                          "https://xn--1lq90ic7f1rc.cn/", false },
+  };
+
+  for (size_t i = 0; i < arraysize(cases); ++i) {
+    SCOPED_TRACE(std::string("input=") + base::WideToUTF8(cases[i].input) +

[Peter Kasting, 2015/06/29 05:04:59]

Nit: I _think_ this compiles without the explicit std::string().

[Mark P, 2015/06/30 04:23:17]

Right you are.  (You found remnants of an earlier iteration of these tests.) 
Done.

+                 " url1=" + cases[i].url1 + " url2=" + cases[i].url2);
+    AutocompleteInput input(
+        base::WideToUTF16(cases[i].input), base::string16::npos, std::string(),
+        GURL(), metrics::OmniboxEventProto::INVALID_SPEC, false, false, true,
+        true, false, TestSchemeClassifier());
+    AutocompleteMatch m1(NULL, 100, false,
+                         AutocompleteMatchType::URL_WHAT_YOU_TYPED);
+    m1.destination_url = GURL(cases[i].url1);
+    m1.ComputeStrippedDestinationURL(input, "zh-CN", NULL);
+    AutocompleteMatch m2(NULL, 100, false,
+                         AutocompleteMatchType::URL_WHAT_YOU_TYPED);
+    m2.destination_url = GURL(cases[i].url2);
+    m2.ComputeStrippedDestinationURL(input, "zh-CN", NULL);
+    EXPECT_EQ(cases[i].expected_duplicate,
+              AutocompleteMatch::DestinationsEqual(m1, m2));
+  }
+}