sdk/lib/_internal/compiler/implementation/ssa/nodes.dart - Issue 109883003: Remove wrong assertion, and make sure we only change the type of constant lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 109883003: Remove wrong assertion, and make sure we only change the type of constant lists. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (revision 31278)

+++ sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (working copy)

@@ -1933,9 +1933,8 @@

bool isCodeMotionInvariant() => true;

set instructionType(type) {

- assert((type.isEmpty && super.instructionType.isEmpty)

- || !type.isNullable);

- assert(!isConstantNull() || (type.isEmpty && type.isNullable));

+ // Only lists can be specialized.

floitsch 2013/12/19 16:16:29 Please add more information.

ngeoffray 2013/12/19 16:17:52 Done.

+ if (!isConstantList()) return;

super.instructionType = type;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »