chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm - Issue 1098823003: Separate USB device permissions prompt logic into subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm

Issue 1098823003: Separate USB device permissions prompt logic into subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm b/chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm

index 21207b72ee75c41b62dd7513de78108a99a7f972..e48e6e0c9577c5cfdea6a0ce33573af0f466903a 100644

--- a/chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm

@@ -29,7 +29,6 @@ using extensions::DevicePermissionsPrompt;

}

- (IBAction)ok:(id)sender {

- __block std::vector<scoped_refptr<device::UsbDevice>> devices;

[[tableView_ selectedRowIndexes]

enumerateIndexesUsingBlock:^(NSUInteger index, BOOL* stop) {

prompt_->GrantDevicePermission(index);

« no previous file with comments | « no previous file | extensions/browser/api/device_permissions_prompt.h » ('j') | extensions/browser/api/device_permissions_prompt.h » ('J')