Separate USB device permissions prompt logic into subclasses.

Separate USB device permissions prompt logic into subclasses.

This patch moves the specific logic for handling USB devices and
device permissions out of the DevicePermissionsPrompt class and into
a set of subclasses that are hidden in device_permissions_prompt.cc.

This should allow a parallel set of subclasses for handling HID devices
to be added without any more modifications to the base classes.

BUG=457899
Committed: https://crrev.com/03256e5f3b29e4c29c102a289757f773e5a624a7
Cr-Commit-Position: refs/heads/master@{#326697}

[Reilly Grant (use Gerrit), 2015-04-22 21:43:03]

reillyg@chromium.org changed reviewers:
+ jyasskin@chromium.org

[Reilly Grant (use Gerrit), 2015-04-22 23:31:08]

Patchset #1 (id:1) has been deleted

[Reilly Grant (use Gerrit), 2015-04-22 23:31:15]

Patchset #1 (id:20001) has been deleted

[Reilly Grant (use Gerrit), 2015-04-22 23:31:30]

Please take a look.

[Jeffrey Yasskin, 2015-04-23 20:40:07]

https://codereview.chromium.org/1098823003/diff/40001/extensions/browser/api/...
File extensions/browser/api/device_permissions_prompt.cc (right):

https://codereview.chromium.org/1098823003/diff/40001/extensions/browser/api/...
extensions/browser/api/device_permissions_prompt.cc:66: scoped_refptr<UsbDevice>
device;
Does this need to own a reference? It looks like the device will be dropped in
OnDeviceRemoved(), which happens before the UsbDevice is destroyed.

https://codereview.chromium.org/1098823003/diff/40001/extensions/browser/api/...
File extensions/browser/api/device_permissions_prompt.h (right):

https://codereview.chromium.org/1098823003/diff/40001/extensions/browser/api/...
extensions/browser/api/device_permissions_prompt.h:41: struct DeviceInfo {
Describe how this is extended. Probably also mark it as a class, since it's now
polymorphic.
https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...

https://codereview.chromium.org/1098823003/diff/40001/extensions/browser/api/...
extensions/browser/api/device_permissions_prompt.h:62: bool multiple);
Comment what "multiple" means.

https://codereview.chromium.org/1098823003/diff/40001/extensions/browser/api/...
extensions/browser/api/device_permissions_prompt.h:90: ScopedVector<DeviceInfo>
devices_;
Please comment the rules on the type of the objects in devices_.

[Reilly Grant (use Gerrit), 2015-04-23 23:02:47]

https://codereview.chromium.org/1098823003/diff/40001/extensions/browser/api/...
File extensions/browser/api/device_permissions_prompt.cc (right):

https://codereview.chromium.org/1098823003/diff/40001/extensions/browser/api/...
extensions/browser/api/device_permissions_prompt.cc:66: scoped_refptr<UsbDevice>
device;
On 2015/04/23 20:40:07, Jeffrey Yasskin wrote:
> Does this need to own a reference? It looks like the device will be dropped in
> OnDeviceRemoved(), which happens before the UsbDevice is destroyed.

Added comments about why this needs to be a strong reference for now.

https://codereview.chromium.org/1098823003/diff/40001/extensions/browser/api/...
File extensions/browser/api/device_permissions_prompt.h (right):

https://codereview.chromium.org/1098823003/diff/40001/extensions/browser/api/...
extensions/browser/api/device_permissions_prompt.h:41: struct DeviceInfo {
On 2015/04/23 20:40:07, Jeffrey Yasskin wrote:
> Describe how this is extended. Probably also mark it as a class, since it's
now
> polymorphic.
>
https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...

Done.

https://codereview.chromium.org/1098823003/diff/40001/extensions/browser/api/...
extensions/browser/api/device_permissions_prompt.h:62: bool multiple);
On 2015/04/23 20:40:07, Jeffrey Yasskin wrote:
> Comment what "multiple" means.

Done.

https://codereview.chromium.org/1098823003/diff/40001/extensions/browser/api/...
extensions/browser/api/device_permissions_prompt.h:90: ScopedVector<DeviceInfo>
devices_;
On 2015/04/23 20:40:07, Jeffrey Yasskin wrote:
> Please comment the rules on the type of the objects in devices_.

Done.

[Jeffrey Yasskin, 2015-04-23 23:38:18]

lgtm

[Reilly Grant (use Gerrit), 2015-04-23 23:44:22]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2015-04-23 23:44:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1098823003/60001

[commit-bot: I haz the power, 2015-04-24 00:19:56]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-04-24 00:20:53]

Patchset 2 (id:??) landed as
https://crrev.com/03256e5f3b29e4c29c102a289757f773e5a624a7
Cr-Commit-Position: refs/heads/master@{#326697}