ui/webui/resources/js/cr/ui/context_menu_handler.js - Issue 1098803002: Context menu is not getting hided in chrome://bookmarks after delete key press.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/context_menu_handler.js

Issue 1098803002: Context menu is not getting hided in chrome://bookmarks after delete key press. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr/ui/context_menu_handler.js

diff --git a/ui/webui/resources/js/cr/ui/context_menu_handler.js b/ui/webui/resources/js/cr/ui/context_menu_handler.js

index d165b69b30af1cea673932dcdd632613644ec5f5..15c52dc20e5d0a71b40be7474cd8a7cecdf47aa3 100644

--- a/ui/webui/resources/js/cr/ui/context_menu_handler.js

+++ b/ui/webui/resources/js/cr/ui/context_menu_handler.js

@@ -169,8 +169,10 @@ cr.define('cr.ui', function() {

this.hideMenu();

e.stopPropagation();

e.preventDefault();

- // If the menu is visible we let it handle all the keyboard events.

+ } else if (e.keyCode == 46 /* Delete */) {

+ this.hideMenu();

+ // If the menu is visible we let it handle all the other keyboard

+ // events.

} else if (this.menu) {

this.menu.handleKeyDown(e);

e.preventDefault();

« no previous file with comments | « no previous file | ui/webui/resources/js/cr/ui/menu_button.js » ('j') | ui/webui/resources/js/cr/ui/menu_button.js » ('J')