Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 10988006: Merge 128999 - Do touch adjustment on GestureTapDown (Closed)

Created:
8 years, 3 months ago by karen
Modified:
8 years, 3 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 128999 - Do touch adjustment on GestureTapDown https://bugs.webkit.org/show_bug.cgi?id=96677 Patch by Rick Byers <rbyers@chromium.org>; on 2012-09-19 Reviewed by Antonio Gomes. Source/WebCore: Do touch adjustment on GestureTapDown exactly as for GestureTap today. Test: touchadjustment/touch-links-active.html * page/EventHandler.cpp: (WebCore::EventHandler::handleGestureEvent): (WebCore::EventHandler::adjustGesturePosition): Tools: Allow radius to be set for GestureTapDown events. * DumpRenderTree/chromium/TestRunner/EventSender.cpp: (EventSender::gestureEvent): LayoutTests: Make a few tweaks to the touchadjustment.js infrastructure to make it simpler and easier to use. Add a test for touch-adjustment of GestureTapDown events (based on touch-links-longpress). * touchadjustment/resources/touchadjustment.js: (touchPoint.return.left.x.radiusX.top.y.radiusY.width.radiusX.2.height.radiusY.2.get x): (touchPoint.return.get y): (touchPoint): (offsetTouchPoint): * touchadjustment/touch-links-active-expected.txt: Added. * touchadjustment/touch-links-active.html: Added. TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -18 lines) Patch
M LayoutTests/platform/qt/Skipped View 2 chunks +4 lines, -3 lines 0 comments Download
M LayoutTests/touchadjustment/resources/touchadjustment.js View 3 chunks +12 lines, -14 lines 0 comments Download
A + LayoutTests/touchadjustment/touch-links-active.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/touchadjustment/touch-links-active-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/page/EventHandler.cpp View 3 chunks +9 lines, -3 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 3 months ago (2012-09-24 22:06:44 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698