Issue 10988004: Revert 158366 - Cleanups in Chromoting Host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10988004: Revert 158366 - Cleanups in Chromoting Host. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)

Modified:
8 years, 3 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 158366 - Cleanups in Chromoting Host. 1. Removed constants.[h|cc] 2. Removed platform if-defs in remoting_me2me_host.cc where they are not necessary. Review URL: https://codereview.chromium.org/10913260 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158400

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -85 lines)			Patch
A +	remoting/host/constants.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/constants_win.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	remoting/host/daemon_process_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	remoting/host/desktop_process.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	remoting/host/dns_blackhole_checker.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
MM	remoting/host/heartbeat_sender.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	remoting/host/host_exit_codes.h	View	1 chunk	+0 lines, -34 lines	0 comments	Download
M	remoting/host/installer/mac/PrivilegedHelperTools/org.chromium.chromoting.me2me.sh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/plugin/daemon_installer_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/remoting_me2me_host.cc	View	11 chunks	+24 lines, -7 lines	0 comments	Download
M	remoting/host/signaling_connector.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	remoting/host/simple_host_process.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	remoting/host/usage_stats_consent_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	remoting/host/win/omaha.h	View	1 chunk	+0 lines, -15 lines	0 comments	Download
D	remoting/host/win/omaha.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
MM	remoting/host/win/wts_session_process_launcher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	remoting/remoting.gyp	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	remoting/tools/me2me_virtual_host.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages