Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1098753004: Remove MSAA check from Ganesh veto (dashed paths are no longer slow). (Closed)

Created:
5 years, 8 months ago by Stephen White
Modified:
5 years, 8 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove MSAA check from Ganesh veto (dashed paths are no longer slow). R=egdaniel@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/31d36b087168486228093f0322898953072f36f2

Patch Set 1 #

Total comments: 2

Patch Set 2 : cleanup per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/core/SkPicture.cpp View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098753004/1
5 years, 8 months ago (2015-04-21 14:40:18 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-21 14:51:29 UTC) #4
Stephen White
Greg: PTAL. Thanks!
5 years, 8 months ago (2015-04-22 20:44:53 UTC) #5
egdaniel
lgtm with the one nit https://codereview.chromium.org/1098753004/diff/1/src/core/SkPicture.cpp File src/core/SkPicture.cpp (right): https://codereview.chromium.org/1098753004/diff/1/src/core/SkPicture.cpp#newcode234 src/core/SkPicture.cpp:234: numSlowPathDashedPaths -= fNumFastPathDashEffects; might ...
5 years, 8 months ago (2015-04-22 20:49:39 UTC) #6
Stephen White
Thanks for your review. https://codereview.chromium.org/1098753004/diff/1/src/core/SkPicture.cpp File src/core/SkPicture.cpp (right): https://codereview.chromium.org/1098753004/diff/1/src/core/SkPicture.cpp#newcode234 src/core/SkPicture.cpp:234: numSlowPathDashedPaths -= fNumFastPathDashEffects; On 2015/04/22 ...
5 years, 8 months ago (2015-04-22 20:53:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098753004/20001
5 years, 8 months ago (2015-04-22 21:28:17 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 21:33:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/31d36b087168486228093f0322898953072f36f2

Powered by Google App Engine
This is Rietveld 408576698