Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 10987103: The real fix of float32. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intrinsifier_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_ia32.cc
===================================================================
--- runtime/vm/intrinsifier_ia32.cc (revision 13046)
+++ runtime/vm/intrinsifier_ia32.cc (working copy)
@@ -559,8 +559,7 @@
}
bool Intrinsifier::Float32Array_getIndexed(Assembler* assembler) {
- // Temporary fix until cvtss2sd is implemented on x64.
- /* Label fall_through;
+ Label fall_through;
TestByteArrayIndex(assembler, &fall_through);
// After TestByteArrayIndex:
// * EAX has the base address of the byte array.
@@ -582,7 +581,7 @@
// Store XMM7 into double instance.
__ movsd(FieldAddress(EAX, Double::value_offset()), XMM7);
__ ret();
- __ Bind(&fall_through); */
+ __ Bind(&fall_through);
return false;
}
« no previous file with comments | « no previous file | runtime/vm/intrinsifier_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698