chrome/browser/password_manager/password_manager_delegate_impl.cc - Issue 10987100: Switch AutofillManager to be UserData on WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager_delegate_impl.cc

Issue 10987100: Switch AutofillManager to be UserData on WebContents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix external delegate Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/password_manager_delegate_impl.cc

diff --git a/chrome/browser/password_manager/password_manager_delegate_impl.cc b/chrome/browser/password_manager/password_manager_delegate_impl.cc

index 3966ba350d8969c1a1edaf4c48072fcb18a72b34..cf1f1ce44d97ebe889b58b8056b11ceccae658d3 100644

--- a/chrome/browser/password_manager/password_manager_delegate_impl.cc

+++ b/chrome/browser/password_manager/password_manager_delegate_impl.cc

@@ -124,7 +124,9 @@ InfoBarDelegate::InfoBarAutomationType

void PasswordManagerDelegateImpl::FillPasswordForm(

const PasswordFormFillData& form_data) {

- bool disable_popup = tab_contents_->autofill_manager()->HasExternalDelegate();

+ AutofillManager* autofill_manager =

+ AutofillManager::FromWebContents(tab_contents_->web_contents());

+ bool disable_popup = autofill_manager->HasExternalDelegate();

tab_contents_->web_contents()->GetRenderViewHost()->Send(

new AutofillMsg_FillPasswordForm(