Switch AutofillManager to be UserData on WebContents.

chrome/browser/autofill/autofill_external_delegate.cc

Index: chrome/browser/autofill/autofill_external_delegate.cc
diff --git a/chrome/browser/autofill/autofill_external_delegate.cc b/chrome/browser/autofill/autofill_external_delegate.cc
index b5c9bd25c98566cfb949ea4abe2f6b8f6a0c7ce5..813186ea4ede3fc1188f6624c06ce007d927e472 100644
--- a/chrome/browser/autofill/autofill_external_delegate.cc
+++ b/chrome/browser/autofill/autofill_external_delegate.cc
@@ -110,7 +110,7 @@ void AutofillExternalDelegate::OnSuggestionsReturned(
     popup_visible_ = true;
     ApplyAutofillSuggestions(values, labels, icons, ids);
 
-    tab_contents_->autofill_manager()->OnDidShowAutofillSuggestions(
+    autofill_manager_->OnDidShowAutofillSuggestions(

[Jói, 2012/10/01 10:45:19]

Is your modification to autofill_external_delegate.h missing from this patch?

[Avi (use Gerrit), 2012/10/01 15:32:26]

What are you referring to? I'm using git so "missing from this patch" doesn't
happen. This patch compiles as-is when applied over the previous one.

What's going on here is that the external delegate is created by passing in both
the tab contents and the manager for it. Everywhere but here, when the manager
is needed it's referred to by the value passed in, not via the TabContents. So
I'm fixing it here.

         has_autofill_item && !has_shown_autofill_popup_for_current_edit_);
     has_shown_autofill_popup_for_current_edit_ |= has_autofill_item;
   }