Switch AutofillManager to be UserData on WebContents.

Switch AutofillManager to be UserData on WebContents.

BUG=107201
TEST=no visible change


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160706

[Jói, 2012-10-01 10:45:19]

LGTM with nits

https://codereview.chromium.org/10987100/diff/1/chrome/browser/autofill/autof...
File chrome/browser/autofill/autofill_external_delegate.cc (right):

https://codereview.chromium.org/10987100/diff/1/chrome/browser/autofill/autof...
chrome/browser/autofill/autofill_external_delegate.cc:113:
autofill_manager_->OnDidShowAutofillSuggestions(
Is your modification to autofill_external_delegate.h missing from this patch?

https://codereview.chromium.org/10987100/diff/1/chrome/browser/autofill/autof...
File chrome/browser/autofill/autofill_manager.cc (left):

https://codereview.chromium.org/10987100/diff/1/chrome/browser/autofill/autof...
chrome/browser/autofill/autofill_manager.cc:904: DCHECK(tab_contents_);
Perhaps keep a DCHECK(web_contents_)?

[Avi (use Gerrit), 2012-10-01 15:32:26]

https://codereview.chromium.org/10987100/diff/1/chrome/browser/autofill/autof...
File chrome/browser/autofill/autofill_external_delegate.cc (right):

https://codereview.chromium.org/10987100/diff/1/chrome/browser/autofill/autof...
chrome/browser/autofill/autofill_external_delegate.cc:113:
autofill_manager_->OnDidShowAutofillSuggestions(
On 2012/10/01 10:45:19, Jói wrote:
> Is your modification to autofill_external_delegate.h missing from this patch?

What are you referring to? I'm using git so "missing from this patch" doesn't
happen. This patch compiles as-is when applied over the previous one.

What's going on here is that the external delegate is created by passing in both
the tab contents and the manager for it. Everywhere but here, when the manager
is needed it's referred to by the value passed in, not via the TabContents. So
I'm fixing it here.

https://codereview.chromium.org/10987100/diff/1/chrome/browser/autofill/autof...
File chrome/browser/autofill/autofill_manager.cc (left):

https://codereview.chromium.org/10987100/diff/1/chrome/browser/autofill/autof...
chrome/browser/autofill/autofill_manager.cc:904: DCHECK(tab_contents_);
On 2012/10/01 10:45:19, Jói wrote:
> Perhaps keep a DCHECK(web_contents_)?

Done. I don't remember why I removed it.

[dhollowa, 2012-10-01 15:37:08]

lgtm

[Jói, 2012-10-01 15:55:59]

LGTM

On Mon, Oct 1, 2012 at 3:37 PM,  <dhollowa@chromium.org> wrote:
> lgtm
>
>
>
> https://codereview.chromium.org/10987100/

[commit-bot: I haz the power, 2012-10-01 21:21:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10987100/11012

[commit-bot: I haz the power, 2012-10-01 21:21:45]

Presubmit check for 10987100-11012 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base
    chrome/browser/password_manager

Presubmit checks took 1.5s to calculate.

[Avi (use Gerrit), 2012-10-01 21:48:43]

Tim: password OWNER
Mark: base OWNER

[Mark Mentovai, 2012-10-01 21:50:10]

LGTM@base

[Ilya Sherman, 2012-10-01 23:23:55]

Passwords LGTM

[commit-bot: I haz the power, 2012-10-01 23:24:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10987100/11012

[commit-bot: I haz the power, 2012-10-02 00:45:34]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-10-02 01:18:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10987100/11012

[commit-bot: I haz the power, 2012-10-02 03:50:43]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-10-02 14:34:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10987100/17010

[commit-bot: I haz the power, 2012-10-02 16:27:11]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-10-02 21:59:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10987100/17010

[commit-bot: I haz the power, 2012-10-03 01:10:30]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-10-08 18:35:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10987100/41001

[commit-bot: I haz the power, 2012-10-08 18:54:33]

Retried try job too often for step(s) interactive_ui_tests, jingle_unittests,
gpu_unittests, base_unittests, sync_integration_tests, sql_unittests,
content_unittests, safe_browsing_tests, ipc_tests, cacheinvalidation_unittests,
remoting_unittests, browser_tests, net_unittests, media_unittests, check_deps,
crypto_unittests, unit_tests, nacl_integration, content_browsertests,
printing_unittests, sandbox_linux_unittests, sync_unit_tests

[commit-bot: I haz the power, 2012-10-08 18:57:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10987100/41001

[commit-bot: I haz the power, 2012-10-08 21:08:56]

Change committed as 160706