Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tests/language/finally_test.dart

Issue 10987073: Fix issue 5517 by setting the successors the right way in a try/catch. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/finally_test.dart
===================================================================
--- tests/language/finally_test.dart (revision 0)
+++ tests/language/finally_test.dart (revision 0)
@@ -0,0 +1,28 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
Søren Gjesse 2012/09/27 15:35:28 This test could also be calle regress_5517_test.da
ngeoffray 2012/09/28 08:20:51 I don't really like giving 'regress_#' names to te
+
+// Test for a bug in dart2js where the update of a field in a try
+// block would not be seen by the finally block.
Søren Gjesse 2012/09/27 15:35:28 Please mention the issue number if not renaming th
ngeoffray 2012/09/28 08:20:51 Done.
+
+class A {
+ int i;
+ A() : i = 42;
+
+ foo() {
+ bool executedFinally = false;
+ if (i === 42) {
+ try {
+ i = 12;
+ } finally {
+ Expect.equals(12, i);
+ executedFinally = true;
+ }
+ }
+ Expect.isTrue(executedFinally);
+ }
+}
+
+main() {
+ new A().foo();
+}

Powered by Google App Engine
This is Rietveld 408576698