Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 10987073: Fix issue 5517 by setting the successors the right way in a try/catch. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/compiler/implementation/ssa/builder.dart ('K') | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/validate.dart » ('j') | tests/language/finally_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/nodes.dart
===================================================================
--- lib/compiler/implementation/ssa/nodes.dart (revision 12963)
+++ lib/compiler/implementation/ssa/nodes.dart (working copy)
@@ -581,8 +581,6 @@
}
void addSuccessor(HBasicBlock block) {
- // Forward branches are only allowed to new blocks.
- assert(isClosed() && (block.isNew() || block.id < id));
ngeoffray 2012/09/27 15:10:05 This assert turns out not being very useful, and m
if (successors.isEmpty()) {
successors = [block];
} else {
« lib/compiler/implementation/ssa/builder.dart ('K') | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/validate.dart » ('j') | tests/language/finally_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698