chrome/browser/performance_monitor/performance_monitor.h - Issue 10987040: Fix CPM casting issue; refactor renderer crash events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/performance_monitor/performance_monitor.h

Issue 10987040: Fix CPM casting issue; refactor renderer crash events (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Comment fix + url as a property again Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/performance_monitor/performance_monitor.h

diff --git a/chrome/browser/performance_monitor/performance_monitor.h b/chrome/browser/performance_monitor/performance_monitor.h

index 0dd1ddab32d845f7c02079bd6f427c52e49a7d1d..ac95b8d64225a0cd9821acb8853e2fbb955b1e3b 100644

--- a/chrome/browser/performance_monitor/performance_monitor.h

+++ b/chrome/browser/performance_monitor/performance_monitor.h

@@ -165,9 +165,10 @@ class PerformanceMonitor : public content::NotificationObserver {

void AddExtensionEvent(EventType type,

const extensions::Extension* extension);

- // Generate an appropriate CrashEvent for a renderer crash and insert it in

- // the database.

- void AddCrashEvent(

+ // Generate an appropriate RendererFailure for a renderer crash and insert it

+ // in the database.

+ void AddRendererClosedEvent(

+ content::RenderProcessHost* host,

const content::RenderProcessHost::RendererClosedDetails& details);

// Called on the IO thread, this will call InsertIOData on the background