chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc - Issue 10987040: Fix CPM casting issue; refactor renderer crash events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

Issue 10987040: Fix CPM casting issue; refactor renderer crash events (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Nit fixes, latest master Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/performance_monitor/performance_monitor_util.cc ('k') | chrome/browser/ui/webui/performance_monitor/performance_monitor_l10n.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

diff --git a/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc b/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

index c4f6170fbc000f2fa413162e9d57663b8105bda6..c26b757c82524bd5cb4c8793bd22e505b90474f6 100644

--- a/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

+++ b/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

@@ -64,9 +64,9 @@ std::set<EventType> GetEventSetForCategory(EventCategory category) {

event_set.insert(EVENT_CHROME_UPDATE);

break;

case EVENT_CATEGORY_EXCEPTIONS:

- event_set.insert(EVENT_RENDERER_FREEZE);

+ event_set.insert(EVENT_RENDERER_HANG);

event_set.insert(EVENT_RENDERER_CRASH);

- event_set.insert(EVENT_KILLED_BY_OS_CRASH);

+ event_set.insert(EVENT_RENDERER_KILLED);

event_set.insert(EVENT_UNCLEAN_EXIT);

break;

default: