Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: lib/html/scripts/dartgenerator.py

Issue 10987019: Refactor file paths handling in generator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/html/scripts/dartgenerator.py
diff --git a/lib/html/scripts/dartgenerator.py b/lib/html/scripts/dartgenerator.py
index 9cdaf1bfaa34f4fc7a7185039cb06460bbf71855..d3e7ba2206f8f3cf8b4e6b197b71e3c7d1e266bc 100755
--- a/lib/html/scripts/dartgenerator.py
+++ b/lib/html/scripts/dartgenerator.py
@@ -11,7 +11,6 @@ import logging
import os
import re
import shutil
-import systembase
from generator import *
_logger = logging.getLogger('dartgenerator')
@@ -189,7 +188,8 @@ class DartGenerator(object):
self.FilterMembersWithUnidentifiedTypes(database)
- def Generate(self, database, system, super_database=None, webkit_renames={}):
+ def Generate(self, database, super_database, webkit_renames,
vsm 2012/09/25 16:06:14 Should this be renamed to Process or similar? It
podivilov1 2012/09/25 16:40:28 Reverted this change. I'll try to decouple dartgen
+ process_interface, process_callback):
Anton Muhin 2012/09/25 16:15:50 why pass callbacks, not some generator?
podivilov1 2012/09/25 16:40:28 Done.
self._database = database
# Collect interfaces
@@ -229,13 +229,10 @@ class DartGenerator(object):
if 'Callback' in interface.ext_attrs:
handlers = [op for op in interface.operations if op.id == 'handleEvent']
info = AnalyzeOperation(interface, handlers)
- system.ProcessCallback(interface, info)
+ process_callback(interface, info)
else:
_logger.info('Generating %s' % interface.id)
- system.ProcessInterface(interface)
-
- system.GenerateLibraries()
- system.Finish()
+ process_interface(interface)
def _PreOrderInterfaces(self, interfaces):
"""Returns the interfaces in pre-order, i.e. parents first."""

Powered by Google App Engine
This is Rietveld 408576698