Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1098683002: [DevTools] Added Event Listeners sidebar in sources panel (Closed)

Created:
5 years, 8 months ago by kozy
Modified:
5 years, 7 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@window-listeners
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Added Event Listeners sidebar in sources panel This sidebar shows event listeners for window object in current context. BUG=469159 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195972

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -1 line) Patch
M Source/devtools/devtools.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 1 2 3 1 chunk +83 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sources/module.json View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
kozy
Pavel, please take a look. Screenshot: https://drive.google.com/a/chromium.org/file/d/0B7RLEApsOKBLRUx4ZnlrNHFZZm8/view?usp=sharing
5 years, 8 months ago (2015-04-17 14:24:02 UTC) #1
pfeldman
Is this up to date?
5 years, 7 months ago (2015-05-15 23:58:01 UTC) #2
kozy
I've uploaded up to date patch set.
5 years, 7 months ago (2015-05-21 13:53:11 UTC) #3
kozy
Pavel, please take a look.
5 years, 7 months ago (2015-05-26 08:50:28 UTC) #4
pfeldman
lgtm
5 years, 7 months ago (2015-05-26 10:07:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098683002/40001
5 years, 7 months ago (2015-05-26 10:08:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/63166)
5 years, 7 months ago (2015-05-26 12:04:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098683002/40001
5 years, 7 months ago (2015-05-26 12:08:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/63853)
5 years, 7 months ago (2015-05-26 13:54:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098683002/80001
5 years, 7 months ago (2015-05-27 11:17:53 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 11:37:53 UTC) #18
Message was sent while issue was closed. 
Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195972

Powered by Google App Engine
This is Rietveld 408576698