Issue 109863003: Use StringPiece for UTF string conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109863003: Use StringPiece for UTF string conversions. (Closed)

Created:
7 years ago by brettw

Modified:
6 years, 4 months ago

Reviewers:

CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use StringPiece for UTF string conversions. This replaces the manual buffer, size arguemnts for the UTF8/16 conversion functions since it makes calling these versions more convenient.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : git try #

Patch Set 4 : #

Patch Set 5 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -33 lines)			Patch
M	base/android/jni_string.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	base/i18n/icu_string_conversions.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	base/strings/utf_string_conversions.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	base/strings/utf_string_conversions.cc	View	1	1 chunk	+12 lines, -12 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/zip_reader.cc	View	1 2 3	1 chunk	+4 lines, -3 lines	0 comments	Download
M	net/cert/x509_cert_types_mac.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	net/dns/dns_config_service_win.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/proxy/proxy_resolver_v8.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	ppapi/proxy/pdf_resource_unittest.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/zlib/google/zip_reader.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/base/clipboard/clipboard_win.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download