Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5697)

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.cc

Issue 10986092: Transparent apps support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address reviewer's comment Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/app_window/app_window_api.cc
diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc
index 2bed9f500d9b5babe969c3658015476cf1ceae03..a510663619cc10869e41f682cec94acbbb321235 100644
--- a/chrome/browser/extensions/api/app_window/app_window_api.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc
@@ -140,8 +140,7 @@ bool AppWindowCreateFunction::RunImpl() {
if (options->frame.get()) {
if (*options->frame == kHtmlFrameOption &&
- CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableExperimentalExtensionApis)) {
+ GetExtension()->HasAPIPermission(APIPermission::kExperimental)) {
create_params.frame = ShellWindow::CreateParams::FRAME_NONE;
inject_html_titlebar = true;
} else if (*options->frame == kNoneFrameOption) {
@@ -151,6 +150,11 @@ bool AppWindowCreateFunction::RunImpl() {
}
}
+ if (options->transparent_background.get() &&
+ GetExtension()->HasAPIPermission(APIPermission::kExperimental)) {
+ create_params.transparent_background = *options->transparent_background;
+ }
+
gfx::Size& minimum_size = create_params.minimum_size;
if (options->min_width.get())
minimum_size.set_width(*options->min_width);
« no previous file with comments | « no previous file | chrome/browser/ui/extensions/shell_window.h » ('j') | chrome/browser/ui/views/extensions/shell_window_views.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698