Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 10986071: Properly factor Native Client defines to support NaCl OS on ARM and x86 (Closed)

Created:
7 years, 1 month ago by Derek Schuff
Modified:
6 years, 2 months ago
Reviewers:
CC:
native-client-reviews_googlegroups.com
Base URL:
http://llvm.org/git/clang.git@master
Visibility:
Public.

Description

Properly factor Native Client defines to support NaCl OS on ARM and x86 Depends on https://codereview.chromium.org/10982073 Upstream review thread at http://comments.gmane.org/gmane.comp.compilers.clang.scm/58483 Committed as LLVM r165722

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -25 lines) Patch
M lib/Basic/Targets.cpp View 1 12 chunks +53 lines, -17 lines 0 comments Download
M lib/CodeGen/TargetInfo.cpp View 1 7 chunks +22 lines, -8 lines 0 comments Download
M test/CodeGen/arm-aapcs-vfp.c View 1 1 chunk +6 lines, -0 lines 0 comments Download
A test/CodeGen/long-double-x86-nacl.c View 1 chunk +7 lines, -0 lines 0 comments Download
A test/CodeGen/x86_64-arguments-nacl.c View 1 1 chunk +92 lines, -0 lines 0 comments Download
A test/Driver/x86_64-nacl-defines.cpp View 1 1 chunk +45 lines, -0 lines 0 comments Download
A test/Driver/x86_64-nacl-types.cpp View 1 1 chunk +36 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698