Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 10986029: Attempt 3 at: Makes tab dragging code set bounds before creating window, that way (Closed)

Created:
8 years, 2 months ago by sky
Modified:
8 years, 2 months ago
CC:
chromium-reviews, tfarina, dcheng
Visibility:
Public.

Description

Attempt 3 at: Makes tab dragging code set bounds before creating window, that way window sizer doesn't kick in and have side effects. This is the same as the first version. I reverted the last (second version) since the waterfall was happy and I need a clean version to merge over. TBR since same as first. BUG=150868 TEST=create a single window with two tabs. Drag tab out and make sure windows don't change position. Also covered by tests now. R=skuhne@chromium.org TBR=skuhne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sky
8 years, 2 months ago (2012-09-25 18:20:44 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698