media/tools/layout_tests/layouttest_analyzer_helpers.py - Issue 10986008: Switch to using WebKit's test expecation parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/tools/layout_tests/layouttest_analyzer_helpers.py

Issue 10986008: Switch to using WebKit's test expecation parser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/tools/layout_tests/layouttest_analyzer_helpers.py

diff --git a/media/tools/layout_tests/layouttest_analyzer_helpers.py b/media/tools/layout_tests/layouttest_analyzer_helpers.py

index b64c25701d0994c46b082d6b6cdfad06a1930353..8612e60e601f56a71f2465cc2e15cdf079f01403 100644

--- a/media/tools/layout_tests/layouttest_analyzer_helpers.py

+++ b/media/tools/layout_tests/layouttest_analyzer_helpers.py

@@ -63,12 +63,10 @@ class AnalyzerResultMap:

for (k, value) in test_info_map.iteritems():

self.result_map['whole'][k] = value

if 'te_info' in value:

- # Don't count SLOW PASS or WONTFIX tests as failures.

+ # Don't count SLOW PASS, WONTFIX, or ANDROID tests as failures.

if any([True for x in value['te_info'] if set(x.keys()) ==

Ami GONE FROM CHROMIUM 2012/09/25 00:40:30 I'm confused by the == (I'd expect a "containedIn"

DaleCurtis 2012/09/25 01:14:50 Doing a subset would match SLOW PASS IMAGE.

- set(['SLOW', 'PASS', 'Bugs', 'Comments']) or 'WONTFIX' in x]):

- continue

- # Ignore failures on the ANDROID platform.

- if value['te_info']['Platforms'] == ['ANDROID']:

+ set(['SLOW', 'PASS', 'Bugs', 'Comments', 'Platforms']) or

Ami GONE FROM CHROMIUM 2012/09/25 00:40:30 indent is off?

DaleCurtis 2012/09/25 01:14:50 Done.

+ 'WONTFIX' in x or x['Platforms'] == ['ANDROID']]):

continue

if any([True for x in value['te_info'] if 'SKIP' in x]):

self.result_map['skip'][k] = value

« no previous file with comments | « no previous file | media/tools/layout_tests/test_expectations.py » ('j') | no next file with comments »