Source/core/layout/LayoutFlexibleBox.h - Issue 1098593002: [css-flexbox] Performance optimization: Only apply min-width: auto when flex-shrinking an item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutFlexibleBox.h

Issue 1098593002: [css-flexbox] Performance optimization: Only apply min-width: auto when flex-shrinking an item (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutFlexibleBox.h

diff --git a/Source/core/layout/LayoutFlexibleBox.h b/Source/core/layout/LayoutFlexibleBox.h

index 29246be4db07896c084c247f080c72e76e7199d0..161c5f2a24b0d44fd513c3db34583065c92bd6bb 100644

--- a/Source/core/layout/LayoutFlexibleBox.h

+++ b/Source/core/layout/LayoutFlexibleBox.h

@@ -144,7 +144,7 @@ private:

LayoutUnit computeChildMarginValue(Length margin);

void prepareOrderIteratorAndMargins();

- LayoutUnit adjustChildSizeForMinAndMax(LayoutBox& child, LayoutUnit childSize);

+ LayoutUnit adjustChildSizeForMinAndMax(LayoutBox& child, LayoutUnit childSize, bool childShrunk);

// The hypothetical main size of an item is the flex base size clamped according to its min and max main size properties

bool computeNextFlexLine(OrderedFlexItemList& orderedChildren, LayoutUnit& sumFlexBaseSize, double& totalFlexGrow, double& totalWeightedFlexShrink, LayoutUnit& sumHypotheticalMainSize, bool relayoutChildren);

« no previous file with comments | « no previous file | Source/core/layout/LayoutFlexibleBox.cpp » ('j') | Source/core/layout/LayoutFlexibleBox.cpp » ('J')