Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: core/src/fxge/ge/fx_ge_fontmap.cpp

Issue 1098583002: Fix a bunch of -Wunused-but-set-variable warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: nits Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/src/fxge/dib/fx_dib_transform.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../../include/fxge/fx_ge.h" 7 #include "../../../include/fxge/fx_ge.h"
8 #include "../../../include/fxge/fx_freetype.h" 8 #include "../../../include/fxge/fx_freetype.h"
9 #include "text_int.h" 9 #include "text_int.h"
10 #define GET_TT_SHORT(w) (FX_WORD)(((w)[0] << 8) | (w)[1]) 10 #define GET_TT_SHORT(w) (FX_WORD)(((w)[0] << 8) | (w)[1])
(...skipping 1349 matching lines...) Expand 10 before | Expand all | Expand 10 after
1360 { 1360 {
1361 FXSYS_FILE* pFile = FXSYS_fopen(path, "rb"); 1361 FXSYS_FILE* pFile = FXSYS_fopen(path, "rb");
1362 if (pFile == NULL) { 1362 if (pFile == NULL) {
1363 return; 1363 return;
1364 } 1364 }
1365 FXSYS_fseek(pFile, 0, FXSYS_SEEK_END); 1365 FXSYS_fseek(pFile, 0, FXSYS_SEEK_END);
1366 FX_DWORD filesize = FXSYS_ftell(pFile); 1366 FX_DWORD filesize = FXSYS_ftell(pFile);
1367 FX_BYTE buffer[16]; 1367 FX_BYTE buffer[16];
1368 FXSYS_fseek(pFile, 0, FXSYS_SEEK_SET); 1368 FXSYS_fseek(pFile, 0, FXSYS_SEEK_SET);
1369 size_t readCnt = FXSYS_fread(buffer, 12, 1, pFile); 1369 size_t readCnt = FXSYS_fread(buffer, 12, 1, pFile);
1370 if (readCnt != 12) {
1371 FXSYS_fclose(pFile);
1372 return;
1373 }
1374
1370 if (GET_TT_LONG(buffer) == 0x74746366) { 1375 if (GET_TT_LONG(buffer) == 0x74746366) {
1371 FX_DWORD nFaces = GET_TT_LONG(buffer + 8); 1376 FX_DWORD nFaces = GET_TT_LONG(buffer + 8);
1372 FX_LPBYTE offsets = FX_Alloc(FX_BYTE, nFaces * 4); 1377 if (nFaces > FX_DWORD_MAX / 4) {
1378 FXSYS_fclose(pFile);
1379 return;
1380 }
1381 FX_DWORD face_bytes = nFaces * 4;
1382 FX_LPBYTE offsets = FX_Alloc(FX_BYTE, face_bytes);
1373 if (!offsets) { 1383 if (!offsets) {
1374 FXSYS_fclose(pFile); 1384 FXSYS_fclose(pFile);
1375 return; 1385 return;
1376 } 1386 }
1377 readCnt = FXSYS_fread(offsets, nFaces * 4, 1, pFile); 1387 readCnt = FXSYS_fread(offsets, face_bytes, 1, pFile);
1388 if (readCnt != face_bytes) {
1389 FXSYS_fclose(pFile);
1390 return;
1391 }
1378 for (FX_DWORD i = 0; i < nFaces; i ++) { 1392 for (FX_DWORD i = 0; i < nFaces; i ++) {
1379 FX_LPBYTE p = offsets + i * 4; 1393 FX_LPBYTE p = offsets + i * 4;
1380 ReportFace(path, pFile, filesize, GET_TT_LONG(p)); 1394 ReportFace(path, pFile, filesize, GET_TT_LONG(p));
1381 } 1395 }
1382 FX_Free(offsets); 1396 FX_Free(offsets);
1383 } else { 1397 } else {
1384 ReportFace(path, pFile, filesize, 0); 1398 ReportFace(path, pFile, filesize, 0);
1385 } 1399 }
1386 FXSYS_fclose(pFile); 1400 FXSYS_fclose(pFile);
1387 } 1401 }
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
1514 return FALSE; 1528 return FALSE;
1515 } 1529 }
1516 CFontFaceInfo* pFont = (CFontFaceInfo*)hFont; 1530 CFontFaceInfo* pFont = (CFontFaceInfo*)hFont;
1517 name = pFont->m_FaceName; 1531 name = pFont->m_FaceName;
1518 return TRUE; 1532 return TRUE;
1519 } 1533 }
1520 FX_BOOL CFX_FolderFontInfo::GetFontCharset(void* hFont, int& charset) 1534 FX_BOOL CFX_FolderFontInfo::GetFontCharset(void* hFont, int& charset)
1521 { 1535 {
1522 return FALSE; 1536 return FALSE;
1523 } 1537 }
OLDNEW
« no previous file with comments | « core/src/fxge/dib/fx_dib_transform.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698