Fix a bunch of -Wunused-but-set-variable warnings.

core/src/fxcodec/codec/fx_codec_jpx_opj.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <algorithm>
 #include <limits>
 
 #include "../../../include/fxcodec/fx_codec.h"
@@ skipping 335 matching lines @@
         sycc444_to_rgb(img);
     } else {
         return;
     }
     img->color_space = OPJ_CLRSPC_SRGB;
 }
 void color_apply_icc_profile(opj_image_t *image)
 {
     cmsHPROFILE in_prof, out_prof;
     cmsHTRANSFORM transform;
-    cmsColorSpaceSignature in_space, out_space;
+    cmsColorSpaceSignature out_space;
     cmsUInt32Number intent, in_type, out_type, nr_samples;
     int *r, *g, *b;
     int prec, i, max, max_w, max_h;
     OPJ_COLOR_SPACE oldspace;
     in_prof =
         cmsOpenProfileFromMem(image->icc_profile_buf, image->icc_profile_len);
     if(in_prof == NULL) {
         return;
     }
-    in_space = cmsGetPCS(in_prof);
     out_space = cmsGetColorSpace(in_prof);

[Tom Sepez, 2015/04/17 16:20:16]

nit: declaration of out_space can move here from line 356.

[Lei Zhang, 2015/05/08 05:40:38]

Done.

     intent = cmsGetHeaderRenderingIntent(in_prof);
     max_w = (int)image->comps[0].w;
     max_h = (int)image->comps[0].h;
     prec = (int)image->comps[0].prec;
     oldspace = image->color_space;
     if(out_space == cmsSigRgbData) {
         if( prec <= 8 ) {
             in_type = TYPE_RGB_8;
             out_type = TYPE_RGB_8;
         } else {
@@ skipping 123 matching lines @@
     numcomps = image->numcomps;
     if(numcomps < 3) {
         return;
     }
     row = (int*)image->icc_profile_buf;
     enumcs = row[0];
     if(enumcs == 14) {
         int *L, *a, *b, *red, *green, *blue, *src0, *src1, *src2;
         double rl, ol, ra, oa, rb, ob, prec0, prec1, prec2;
         double minL, maxL, mina, maxa, minb, maxb;
-        unsigned int default_type, il;
-        unsigned int i, max, illu;
+        unsigned int default_type;
+        unsigned int i, max;
         cmsHPROFILE in, out;
         cmsHTRANSFORM transform;
         cmsUInt16Number RGB[3];
         cmsCIELab Lab;
-        illu = 0;
-        il = 0;
         in = cmsCreateLab4Profile(NULL);
         out = cmsCreate_sRGBProfile();
         transform =
             cmsCreateTransform(in, TYPE_Lab_DBL, out, TYPE_RGB_16,
                                INTENT_PERCEPTUAL, 0);
         cmsCloseProfile(in);
         cmsCloseProfile(out);
         if(transform == NULL) {
             return;
         }
@@ skipping 173 matching lines @@
 {
     width = (FX_DWORD)image->x1;
     height = (FX_DWORD)image->y1;
     output_nComps = codestream_nComps = (FX_DWORD)image->numcomps;
 }
 FX_BOOL CJPX_Decoder::Decode(FX_LPBYTE dest_buf, int pitch, FX_BOOL bTranslateColor, FX_LPBYTE offsets)
 {
     FX_BYTE** channel_bufs;
     int* adjust_comps;
     int i, wid, hei, row, col, channel, src;
-    FX_BOOL flag;
     FX_LPBYTE pChannel, pScanline, pPixel;
 
     if(image->comps[0].w != image->x1 || image->comps[0].h != image->y1) {
         return FALSE;
     }
     if(pitch < (int)(image->comps[0].w * 8 * image->numcomps + 31) >> 5 << 2) {
         return FALSE;
     }
     FXSYS_memset8(dest_buf, 0xff, image->y1 * pitch);
     channel_bufs = FX_Alloc(FX_BYTE*, image->numcomps);
     if (channel_bufs == NULL) {
         return FALSE;
     }
     adjust_comps = FX_Alloc(int, image->numcomps);
     if (adjust_comps == NULL) {
         FX_Free(channel_bufs);
         return FALSE;
     }
-    flag = TRUE;
     for (i = 0; i < (int)image->numcomps; i ++) {
         channel_bufs[i] = dest_buf + offsets[i];
         adjust_comps[i] = image->comps[i].prec - 8;
         if(i > 0) {
             if(image->comps[i].dx != image->comps[i - 1].dx
                     || image->comps[i].dy != image->comps[i - 1].dy
                     || image->comps[i].prec != image->comps[i - 1].prec) {
-                flag = FALSE;
                 goto failed;
             }
         }
     }
     wid = image->comps[0].w;
     hei = image->comps[0].h;
     for (channel = 0; channel < (int)image->numcomps; channel++) {
         pChannel = channel_bufs[channel];
         if(adjust_comps[channel] < 0) {
             for(row = 0; row < hei; row++) {
@@ skipping 31 matching lines @@
                         *pPixel = (FX_BYTE)tmpPixel;
                     }
                 }
             }
         }
     }
 
     FX_Free(channel_bufs);
     FX_Free(adjust_comps);
     return TRUE;
 failed:

[Tom Sepez, 2015/04/17 16:20:16]

using |flag| might have avoided this code duplication. This is screaming for
unique_ptr, which I am going to add one of these days.

I suppose you could:
1. change |failed:| to |done:| for clarity
2. change |flag| to |result| for clarity
3. remove the duplicated code
4. test channel_bufs and ajdust_comps before freeing them.
5. initialize channel_bufs and adjust_comps to NULL up top.
6. conver returns to goto done.

If you wanted to be a crufty C programmer.  Or just leave it.

[Lei Zhang, 2015/05/08 05:40:38]

Done. I'll work on the beard.

     FX_Free(channel_bufs);
     FX_Free(adjust_comps);
     return FALSE;
 }
 void initialize_transition_table();
 void initialize_significance_luts();
 void initialize_sign_lut();
 CCodec_JpxModule::CCodec_JpxModule()
 {
 }
@@ skipping 16 matching lines @@
 FX_BOOL CCodec_JpxModule::Decode(void* ctx, FX_LPBYTE dest_data, int pitch, FX_BOOL bTranslateColor, FX_LPBYTE offsets)
 {
     CJPX_Decoder* pDecoder = (CJPX_Decoder*)ctx;
     return pDecoder->Decode(dest_data, pitch, bTranslateColor, offsets);
 }
 void CCodec_JpxModule::DestroyDecoder(void* ctx)
 {
     CJPX_Decoder* pDecoder = (CJPX_Decoder*)ctx;
     delete pDecoder;
 }