Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1098513002: Reland: Fix errors found in Mac gn component builds (Closed)

Created:
5 years, 8 months ago by Jiang Jiang
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, tim+watch_chromium.org, hclam+watch_chromium.org, imcheng+watch_chromium.org, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, hguihot+watch_chromium.org, avayvod+watch_chromium.org, maxbogue+watch_chromium.org, jam, rickyz+watch_chromium.org, plaree+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, piman+watch_chromium.org, maniscalco+watch_chromium.org, tfarina, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Fix errors found in Mac gn component builds This is relanding https://codereview.chromium.org/1087873003 which was reverted in https://codereview.chromium.org/1089773003/. Mac gn component build fail because of missing frameworks and missing some other dependencies, and occasionally file list out of sync with the gyp counterpart: http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/321/steps/compile/logs/stdio For instance, the frameworks linked in the components that sync depends on is not automatically linked into sync, thus revealing the issue. BUG=477710 Committed: https://crrev.com/2bd42fdbfab81b645ac926bd115e2a0762426b64 Cr-Commit-Position: refs/heads/master@{#325771}

Patch Set 1 #

Patch Set 2 : Should be able to see the target now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -44 lines) Patch
M content/browser/BUILD.gn View 2 chunks +12 lines, -2 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +10 lines, -1 line 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 chunk +9 lines, -0 lines 0 comments Download
M media/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M media/base/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M media/base/mac/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M media/cast/BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download
M media/cast/cast.gyp View 1 chunk +12 lines, -0 lines 0 comments Download
M sandbox/mac/BUILD.gn View 1 2 chunks +38 lines, -37 lines 0 comments Download
M sync/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M sync/sync.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
A + third_party/sudden_motion_sensor/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/accelerated_widget_mac/BUILD.gn View 1 chunk +7 lines, -1 line 0 comments Download
M ui/accelerated_widget_mac/accelerated_widget_mac.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/surface/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/surface/surface.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Jiang Jiang
Brett, can you take a look again? The only change is the one in //sandbox/mac/BUILD.gn ...
5 years, 8 months ago (2015-04-16 21:15:20 UTC) #2
brettw
lgtm
5 years, 8 months ago (2015-04-16 21:16:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098513002/20001
5 years, 8 months ago (2015-04-16 21:21:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/47746)
5 years, 8 months ago (2015-04-17 00:03:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098513002/20001
5 years, 8 months ago (2015-04-17 04:54:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/49280) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 8 months ago (2015-04-17 06:37:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098513002/20001
5 years, 8 months ago (2015-04-17 20:30:35 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/58445)
5 years, 8 months ago (2015-04-17 21:35:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098513002/20001
5 years, 8 months ago (2015-04-18 06:15:53 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-18 13:29:14 UTC) #18
commit-bot: I haz the power
5 years, 8 months ago (2015-04-18 13:30:11 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2bd42fdbfab81b645ac926bd115e2a0762426b64
Cr-Commit-Position: refs/heads/master@{#325771}

Powered by Google App Engine
This is Rietveld 408576698