NativeThemeAndroid should inherit from NativeThemeBase

NativeThemeAndroid should inherit from NativeThemeBase

NativeThemeAndroid currently re-implements every method defined in the
NativeTheme class by duplicating the code, while it didn't actually modify
behavior. By changing its base class to NativeThemeBase, which has most
of the code we need, we only have to override GetSystemColor.

Visually, this lines up Android's button appearance with Linux, as Android's
code hadn't been updated for changing coming in to the general implementation.
It also enables the new checkbox appearance all of Chrome will be switching
too. Removing the old code is being tracked in Issue 133991.

BUG=152912
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159483

[Peter Beverloo, 2012-09-28 11:15:35]

+Xianzhu for Android
+Scott for ui/ OWNERS

[Rick Byers, 2012-09-28 13:09:30]

Looks like a great clean-up to me.  I didn't exhaustively verify that there's no
other change in behavior.
LGTM

[sky, 2012-09-28 15:51:10]

I'm rubber stamping this and assuming Xianzhu will do a review.

[Xianzhu, 2012-09-28 16:20:32]

LGTM. FYI we are likely to change the code to paint the web controls to use
higher density images according to the device scale (and maybe also page scale).
Tracked with crbug.com/150792. Possibly we'll add back some methods, but for now
it's good to remove the duplicated code.

[Peter Beverloo, 2012-09-30 08:04:12]

Thanks guys, that seems good to me. Putting this on the commit queue.

[commit-bot: I haz the power, 2012-09-30 08:04:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peter@chromium.org/10985076/2001

[commit-bot: I haz the power, 2012-09-30 08:04:21]

Presubmit check for 10985076-2001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ui

[sky, 2012-09-30 23:59:32]

Forgot the rubber stamp: LGTM

[commit-bot: I haz the power, 2012-09-30 23:59:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peter@chromium.org/10985076/2001

[commit-bot: I haz the power, 2012-10-01 00:03:23]

Retried try job too often for step(s) compile