Extensions Docs Server: Show properties of properties in the table of contents

chrome/common/extensions/docs/templates/private/parameter_full.html

Index: chrome/common/extensions/docs/templates/private/parameter_full.html
diff --git a/chrome/common/extensions/docs/templates/private/parameter_full.html b/chrome/common/extensions/docs/templates/private/parameter_full.html
index efc1f3363823c7fc3dda6ce4fd17d0d258213409..5f4f3084e6aa5f3fedc37a9dc44faf7c031a14e7 100644
--- a/chrome/common/extensions/docs/templates/private/parameter_full.html
+++ b/chrome/common/extensions/docs/templates/private/parameter_full.html
@@ -1,4 +1,5 @@
 <div>
+  {{?prefix}}<a name="{{?property}}property{{:}}type{{/}}-{{prefix}}-{{name}}"></a>{{/}}

[not at google - send to devlin, 2012/09/28 04:03:11]

blarg, it would be nicer if this link were in the form of an id on the property
(as in, property.html have <span class="..." id="{{id}}">

however, that involves generating this "id" thing in the server.

That... would be really neat. It would clean up all these "prefix" shenanigans:

 > git grep prefix

api_property.html:      {{+partials.parameter_full prefix:property.name
property:true}}
event.html:  <a name="event-{{?prefix}}{{prefix}}-{{/}}{{name}}"></a>
event.html:    <span
class="subdued">{{?prefix}}{{prefix}}{{:}}chrome.{{api.name}}{{/}}.</span>{{name}}<span
class="subdued">.addListener</span>(function({{#parameters}}{{+partia
function.html:  <a name="method-{{?prefix}}{{prefix}}-{{/}}{{name}}"></a>
function.html:    <span>{{?returns}}{{+partials.variable_type}}
{{/}}{{?prefix}}{{prefix}}{{:}}chrome.{{api.name}}{{/}}.{{name}}</span>({{#parameters}}{{+partials.parameter_item}
parameter_full.html:  {{?prefix}}<a
name="{{?property}}property{{:}}type{{/}}-{{prefix}}-{{name}}"></a>{{/}}
toc_events.html:<a href="#{{?prefix}}{{prefix}}-{{/}}events">Events</a>
toc_events.html:  <li><a
href="#event-{{?prefix}}{{prefix}}-{{/}}{{name}}">{{name}}</a></li>
toc_functions.html:<a href="#{{?prefix}}{{prefix}}-{{/}}methods">Methods</a>
toc_functions.html:  <li><a
href="#method-{{?prefix}}{{prefix}}-{{/}}{{name}}">{{name}}</a></li>
toc_properties.html:<a
href="#{{?prefix}}{{prefix}}-{{/}}properties">Properties</a>
toc_properties.html:    <a
href="#property-{{?prefix}}{{prefix}}-{{/}}{{name}}">{{name}}</a>
toc_properties.html:    {{?functions}}<ol><li>{{+partials.toc_functions
prefix:name}}</li></ol>{{/}}
toc_properties.html:    {{?events}}<ol><li>{{+partials.toc_events
prefix:name}}</li></ol>{{/}}
toc_properties.html:    {{?properties}}<ol><li>{{+partials.toc_properties
prefix:name}}</li></ol>{{/}}
toc_types.html:<a href="#{{?prefix}}{{prefix}}-{{/}}types">Types</a>
toc_types.html:    <a
href="#type-{{?prefix}}{{prefix}}-{{/}}{{name}}">{{name}}</a>
toc_types.html:    {{?functions}}<ol><li>{{+partials.toc_functions
prefix:name}}</li></ol>{{/}}
toc_types.html:    {{?events}}<ol><li>{{+partials.toc_events
prefix:name}}</li></ol>{{/}}
type.html:      {{+partials.parameter_full prefix:type.name}}
type.html:      <dd><dl>{{#functions}}{{+partials.function api:api
prefix:type.name}}{{/}}</dl></dd>
type.html:      <dd><dl>{{#events}}{{+partials.event api:api
prefix:type.name}}{{/}}</dl></dd>


However, it would require a change to the server, and then we'd need to
coordinate pushing this change with updating the server. Not a big deal, we just
need to submit it in 2 separate changes.

But at least that change would be testable, though. What do you think?

[cduvall, 2012/09/29 00:37:49]

I think this would be awesome. I'm going to upload a separate patch for the
server changes that this patch will depend on. The server changes are here:
https://codereview.chromium.org/11018003/

   {{+partials.property}}
   {{?properties}}

[not at google - send to devlin, 2012/09/28 04:03:11]

also, 80 chars if possible

[cduvall, 2012/09/29 00:37:49]

Done.

   <dd>