chrome/common/extensions/docs/templates/private/api_property.html - Issue 10985071: Extensions Docs Server: Show properties of properties in the table of contents

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/api_property.html

Issue 10985071: Extensions Docs Server: Show properties of properties in the table of contents (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | chrome/common/extensions/docs/templates/private/api_reference.html » ('j') | chrome/common/extensions/docs/templates/private/api_reference.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div>	1 <div>

2 <a name="property-{{name}}"></a>	2 <a name="property-{{name}}"></a>
	not at google - send to devlin 2012/09/28 04:03:11 move name onto id of the property move name onto id of the property cduvall 2012/09/29 00:37:49 Done. Show quoted text On 2012/09/28 04:03:11, kalman wrote: > move name onto id of the property Done.
3 <h4>{{name}}</h4>	3 <h4>{{name}}</h4>

4 <div class="summary">	4 <div class="summary">

5 <span>chrome.{{api.name}}.{{name}}</span>	5 <span>chrome.{{api.name}}.{{name}}</span>

6 </div>	6 </div>

7 <div>	7 <div>

8 <dt><span class="property">{{name}}</span> {{+partials.type_name}}</dt>	8 <dt><span class="property">{{name}}</span> {{+partials.type_name}}</dt>

9 {{?description}}<dd>	9 {{?description}}<dd>

10 {{{description}}}	10 {{{description}}}

11 </dd>{{/description}}	11 </dd>{{/description}}

12 <dd><dl>{{#properties}}{{+partials.property}}{{/}}</dl></dd>	12 {{?properties}}

13 <dd><dl>{{#functions}}{{+partials.function}}{{/}}</dl></dd>	13 <a name={{property.name}}-properties></a>
	not at google - send to devlin 2012/09/28 04:03:11 I think this should actually be a <h4 id="...">Pro I think this should actually be a <h4 id="...">Properties of {{name}}</h4>, it looks much neater. Or even <h4 id="...">Properties of <a href="#property-{{name}}">{{name}}</a></h4> (btw don't forget to put quotations around the attribute) cduvall 2012/09/29 00:37:49 Done. Show quoted text On 2012/09/28 04:03:11, kalman wrote: > I think this should actually be a <h4 id="...">Properties of {{name}}</h4>, it > looks much neater. > > Or even > > <h4 id="...">Properties of <a href="#property-{{name}}">{{name}}</a></h4> > > (btw don't forget to put quotations around the attribute) Done.
	14 <dd><dl>{{#properties}}

	15 {{+partials.parameter_full prefix:property.name property:true}}
	not at google - send to devlin 2012/09/28 04:03:11 "is_property" would be less confusing "is_property" would be less confusing cduvall 2012/09/29 00:37:49 Done. Show quoted text On 2012/09/28 04:03:11, kalman wrote: > "is_property" would be less confusing Done.
	16 {{/}}</dl></dd>

	17 {{/properties}}

	18 {{?functions}}

	19 <a name={{property.name}}-functions></a>
	not at google - send to devlin 2012/09/28 04:03:11 ditto ditto cduvall 2012/09/29 00:37:49 Done. Show quoted text On 2012/09/28 04:03:11, kalman wrote: > ditto Done.
	20 <dd><dl>{{#functions}}

	21 {{+partials.function}}

	22 {{/}}</dl></dd>

	23 {{/functions}}

14 </div>	24 </div>

15 </div>	25 </div>

OLD	NEW