Whitelist the University of Illinois Opensource License (http://llvm.org/releases/3.1/LICENSE.TXT) …

Whitelist the University of Illinois Opensource License (http://llvm.org/releases/3.1/LICENSE.TXT) for the LLVM bits.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159683

[Alexander Potapenko, 2012-09-27 14:48:13]

Lei, Pawel, is this the right way to add a new license?
If so, can you approve this, please?

[Lei Zhang, 2012-09-27 18:21:13]

I think you need to update third_party/devscripts/licensecheck.pl first so it
knows how to identify the license.

[Paweł Hajdan Jr., 2012-09-28 06:52:04]

Generally this is the right way provided you got an error about a license, but
in this CL it's weird that licensecheck.pl doesn't seem to be using that license
name (what Lei said), so this CL is effectively a no-op.

I'd suggest you to start with a local copy of llvm bits and run checklicenses.py
on it. In case of any errors, proceed as described on
http://www.chromium.org/developers/adding-3rd-party-libraries and of course feel
free to ask me if you have any questions.

[Alexander Potapenko, 2012-09-28 12:37:21]

I've added the license to licensecheck.pl so that checklicenses.py doesn't print
any warnings about LLVM code for me locally.

[Paweł Hajdan Jr., 2012-09-28 13:59:42]

LGTM with comments.

https://codereview.chromium.org/10985065/diff/5001/third_party/devscripts/lic...
File third_party/devscripts/licensecheck.pl (right):

https://codereview.chromium.org/10985065/diff/5001/third_party/devscripts/lic...
third_party/devscripts/licensecheck.pl:437: if ($licensetext  =~ /This file is
distributed under the University of Illinois Open Source License. See
LICENSE.TXT for details./){
nit: No need to include "See LICENSE.TXT for details" bit in the regex.

https://codereview.chromium.org/10985065/diff/5001/third_party/devscripts/lic...
third_party/devscripts/licensecheck.pl:438: $license = "University of Illinois
Open Source License (BSD like) $license";
nit: Include NCSA in the name, e.g. NCSA/University of Illinois ...

[Alexander Potapenko, 2012-10-02 10:46:18]

https://codereview.chromium.org/10985065/diff/5001/third_party/devscripts/lic...
File third_party/devscripts/licensecheck.pl (right):

https://codereview.chromium.org/10985065/diff/5001/third_party/devscripts/lic...
third_party/devscripts/licensecheck.pl:437: if ($licensetext  =~ /This file is
distributed under the University of Illinois Open Source License. See
LICENSE.TXT for details./){
On 2012/09/28 13:59:42, Paweł Hajdan Jr. wrote:
> nit: No need to include "See LICENSE.TXT for details" bit in the regex.

Done.

https://codereview.chromium.org/10985065/diff/5001/third_party/devscripts/lic...
third_party/devscripts/licensecheck.pl:438: $license = "University of Illinois
Open Source License (BSD like) $license";
On 2012/09/28 13:59:42, Paweł Hajdan Jr. wrote:
> nit: Include NCSA in the name, e.g. NCSA/University of Illinois ...
Done. "University of Illinois/NCSA" is used more widely

[Paweł Hajdan Jr., 2012-10-02 11:01:30]

LGTM with a nit.

https://codereview.chromium.org/10985065/diff/10001/third_party/devscripts/li...
File third_party/devscripts/licensecheck.pl (right):

https://codereview.chromium.org/10985065/diff/10001/third_party/devscripts/li...
third_party/devscripts/licensecheck.pl:437: if ($licensetext  =~ /This file is
distributed under the University of Illinois Open Source License./){
nit: I forgot about it earlier, but if possible (i.e. continues to work), quote
the dot, which matches any character unless quoted.

[Alexander Potapenko, 2012-10-02 11:39:33]

https://codereview.chromium.org/10985065/diff/10001/third_party/devscripts/li...
File third_party/devscripts/licensecheck.pl (right):

https://codereview.chromium.org/10985065/diff/10001/third_party/devscripts/li...
third_party/devscripts/licensecheck.pl:437: if ($licensetext  =~ /This file is
distributed under the University of Illinois Open Source License./){
On 2012/10/02 11:01:31, Paweł Hajdan Jr. wrote:
> nit: I forgot about it earlier, but if possible (i.e. continues to work),
quote
> the dot, which matches any character unless quoted.

I've just removed the dot.