Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10985050: New getting started tutorial for sencha media player app. (Closed)

Created:
8 years, 2 months ago by mkearney1
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

New getting started tutorial for sencha media player app. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161375

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Total comments: 2

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+584 lines, -1 line) Patch
A chrome/common/extensions/docs/templates/articles/sencha_framework.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +578 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/apps_sidenav.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/sencha_framework.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
PaulKinlan
Just noticed a spelling mistake, but otherwise great. https://codereview.chromium.org/10985050/diff/11001/chrome/common/extensions/docs/templates/articles/sencha_framework.html File chrome/common/extensions/docs/templates/articles/sencha_framework.html (right): https://codereview.chromium.org/10985050/diff/11001/chrome/common/extensions/docs/templates/articles/sencha_framework.html#newcode533 chrome/common/extensions/docs/templates/articles/sencha_framework.html:533: This ...
8 years, 2 months ago (2012-10-04 08:18:51 UTC) #1
PaulKinlan
Just noticed a spelling mistake, but otherwise great.
8 years, 2 months ago (2012-10-04 08:18:52 UTC) #2
mkearney1
https://codereview.chromium.org/10985050/diff/11001/chrome/common/extensions/docs/templates/articles/sencha_framework.html File chrome/common/extensions/docs/templates/articles/sencha_framework.html (right): https://codereview.chromium.org/10985050/diff/11001/chrome/common/extensions/docs/templates/articles/sencha_framework.html#newcode533 chrome/common/extensions/docs/templates/articles/sencha_framework.html:533: This intiates the onload callback which checks the received ...
8 years, 2 months ago (2012-10-09 22:40:42 UTC) #3
mkearney1
Mihai, Paul has reviewed this and I've fixed the spelling mistake - I just need ...
8 years, 2 months ago (2012-10-10 18:58:23 UTC) #4
Mihai Parparita -not on Chrome
LGTM
8 years, 2 months ago (2012-10-11 17:08:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/10985050/19001
8 years, 2 months ago (2012-10-11 17:09:04 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-11 17:09:40 UTC) #7 
Presubmit check for 10985050-19001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
File
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/templates/articles/sencha_framework.html
needs an id for each heading.

Presubmit checks took 33.0s to calculate.

Powered by Google App Engine
This is Rietveld 408576698