Implement redirect() API for Fetch Response

Source/modules/fetch/Response.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/fetch/Response.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/DOMArrayBuffer.h"
@@ skipping 224 matching lines @@
 
 Response* Response::error(ExecutionContext* context)
 {
     FetchResponseData* responseData = FetchResponseData::createNetworkErrorResponse();
     Response* r = new Response(context, responseData);
     r->m_headers->setGuard(Headers::ImmutableGuard);
     r->suspendIfNeeded();
     return r;
 }
 
+Response* Response::redirect(ExecutionContext* context, const String& url, unsigned short status, ExceptionState& exceptionState)
+{
+    KURL parsedURL = context->completeURL(url);
+    if (!parsedURL.isValid()) {
+        exceptionState.throwTypeError("Failed to parse URL from " + url);
+        return nullptr;
+    }
+
+    if (status !=301 && status !=302 && status !=303 && status !=307 && status !=308) {

[tyoshino (SeeGerritForStatus), 2015/04/20 04:31:44]

put a space between != and the second operand

[horo, 2015/04/20 04:32:12]

spaces after "!="

if (status != 301 && status != 302 && status != 303 && status != 307 && status
!= 308) {

[shiva.jm, 2015/04/27 10:50:55]

Done.

[shiva.jm, 2015/04/27 10:50:55]

Done.

+        exceptionState.throwRangeError("Invalid statusCode");

[tyoshino (SeeGerritForStatus), 2015/04/20 04:50:00]

statusCode -> status, since the argument name in the spec is "status".

Or "statusCode" -> "status code" if you want to emphasize it's status code.

[shiva.jm, 2015/04/27 10:50:55]

Done. changed to "status code"

+        return nullptr;
+    }
+
+    Response* r = new Response(context);
+    r->m_headers->setGuard(Headers::ImmutableGuard);
+    r->suspendIfNeeded();

[yhirano, 2015/04/20 04:55:30]

Please call |suspendIfNeeded| right after creation.

[shiva.jm, 2015/04/27 10:50:55]

Done.

+    r->m_response->setStatus(status);
+    r->m_response->headerList()->set("Location", parsedURL);
+
+    return r;
+}
+
 String Response::type() const
 {
     // "The type attribute's getter must return response's type."
     switch (m_response->type()) {
     case FetchResponseData::BasicType:
         return "basic";
     case FetchResponseData::CORSType:
         return "cors";
     case FetchResponseData::DefaultType:
         return "default";
@@ skipping 125 matching lines @@
 }
 
 DEFINE_TRACE(Response)
 {
     Body::trace(visitor);
     visitor->trace(m_response);
     visitor->trace(m_headers);
 }
 
 } // namespace blink