lib/compiler/implementation/ssa/optimize.dart - Issue 10984070: Fix another assert triggered by host-checked mode: only register fields to the backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/optimize.dart

Issue 10984070: Fix another assert triggered by host-checked mode: only register fields to the backend. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/ssa/optimize.dart

===================================================================

--- lib/compiler/implementation/ssa/optimize.dart (revision 12963)

+++ lib/compiler/implementation/ssa/optimize.dart (working copy)

@@ -1302,7 +1302,8 @@

Element field = node.element;

HInstruction value = node.value;

HType type = types[value];

- allSetters.add(field);

+ // [HFieldSet] is also used for variables in try/catch.

+ if (field.isField()) allSetters.add(field);

// Don't handle fields defined in superclasses. Given that the field is

// always added to the [allSetters] set, setting a field defined in a

// superclass will get an inferred type of UNKNOWN.

« no previous file with comments | « no previous file | no next file » | no next file with comments »