Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 10984039: Merge a libxml clang warning fix (Closed)

Created:
8 years, 2 months ago by hans
Modified:
8 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Merge a libxml clang warning fix This fixes the following warning: /usr/local/google/work/chrome/src/third_party/libxml/src/xpath.c:12269:13: warning: comparison of constant 18 with expression of type 'xmlXPathTypeVal' is always false [-Wtautological-constant-out-of-range-compare] if (type == XML_NAMESPACE_DECL) ~~~~ ^ ~~~~~~~~~~~~~~~~~~ The upstream fix is at http://git.gnome.org/browse/libxml2/commit/?id=713434d2309da469d64b35e163ea6556dadccada TEST=none BUG=151927 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/libxml/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libxml/src/xpath.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hans
8 years, 2 months ago (2012-09-26 08:52:52 UTC) #1
Nico
lgtm The upstream patch assumes that out-of-enum assignments don't do anything weird. type == cur->type ...
8 years, 2 months ago (2012-09-26 08:55:07 UTC) #2
hans
On 2012/09/26 08:55:07, Nico wrote: > lgtm > > The upstream patch assumes that out-of-enum ...
8 years, 2 months ago (2012-09-26 09:05:12 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 09:05:20 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698