Issue 10984034: Revert 158691 - Give platform apps control over launcher right-click context menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10984034: Revert 158691 - Give platform apps control over launcher right-click context menu. (Closed)

Created:
8 years, 2 months ago by csilv

Modified:
8 years, 2 months ago

Reviewers:
Marijn Kruisselbrink

CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, ben+watch_chromium.org, tfarina, Aaron Boodman, ajwong+watch_chromium.org, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 158691 - Give platform apps control over launcher right-click context menu. This moves most of the extension context menu related code from RenderViewContextMenu to a seperate class, which is then used in two other places as well. Reverted due to failures on Mac testers in: ExtensionContextMenuBrowserLazyTest.EventPage http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20(dbg)(1)/builds/1693/steps/browser_tests/logs/EventPage BUG=143222 Review URL: https://chromiumcodereview.appspot.com/10918103 TBR=mek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158705

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+274 lines, -473 lines)			Patch
M	chrome/browser/extensions/api/context_menu/context_menu_api.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/browser/extensions/context_menu_matcher.h	View	1 chunk	+0 lines, -86 lines	0 comments	Download
D	chrome/browser/extensions/context_menu_matcher.cc	View	1 chunk	+0 lines, -231 lines	0 comments	Download
M	chrome/browser/extensions/extension_context_menu_browsertest.cc	View	7 chunks	+45 lines, -56 lines	0 comments	Download
M	chrome/browser/extensions/menu_manager.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.h	View	5 chunks	+25 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	9 chunks	+198 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/app_list/extension_app_item.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/app_list/extension_app_item.cc	View	7 chunks	+0 lines, -24 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/launcher_context_menu.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/launcher_context_menu.cc	View	5 chunks	+3 lines, -27 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/context_menus.json	View	3 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages