Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1098403002: Update the extension whitelist for application host change. (Closed)

Created:
5 years, 8 months ago by jiayl
Modified:
5 years, 8 months ago
Reviewers:
tommi (sloooow) - chröme, bemasc, bemascc
CC:
arv+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the extension whitelist for application host change. BUG= Committed: https://crrev.com/29b6f6fa8785ed80c2fcf043bb0619f3f8b80065 Cr-Commit-Position: refs/heads/master@{#326534} Committed: https://crrev.com/0a7a6691adb4ab51c9e5ab68e8f4c6007039e139 Cr-Commit-Position: refs/heads/master@{#326682}

Patch Set 1 #

Patch Set 2 : fix pattern #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/hangout_services/manifest.json View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 21 (8 generated)
jiayl
PTAL
5 years, 8 months ago (2015-04-22 18:55:40 UTC) #2
bemasc
lgtm
5 years, 8 months ago (2015-04-22 21:16:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098403002/1
5 years, 8 months ago (2015-04-22 21:35:36 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-22 21:35:39 UTC) #7
jiayl
Tommi, PTAL
5 years, 8 months ago (2015-04-22 21:37:04 UTC) #9
tommi (sloooow) - chröme
lgtm
5 years, 8 months ago (2015-04-23 14:33:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098403002/1
5 years, 8 months ago (2015-04-23 15:44:18 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 16:16:18 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/29b6f6fa8785ed80c2fcf043bb0619f3f8b80065 Cr-Commit-Position: refs/heads/master@{#326534}
5 years, 8 months ago (2015-04-23 16:17:17 UTC) #15
jiayl
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1093893004/ by jiayl@chromium.org. ...
5 years, 8 months ago (2015-04-23 20:06:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098403002/20001
5 years, 8 months ago (2015-04-23 21:55:26 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 22:53:10 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 22:54:10 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a7a6691adb4ab51c9e5ab68e8f4c6007039e139
Cr-Commit-Position: refs/heads/master@{#326682}

Powered by Google App Engine
This is Rietveld 408576698