Call exit(1) if we mean to crash, rather than *(char*)0 = 0

Call exit(1) if we mean to crash, rather than *(char*)0 = 0
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158877

[reed1, 2012-09-26 14:38:22]

*(char*)0 = 0;

This does not seems to always crash for me. I wonder if this could be a cause of
a canvas allocation failing but us not crashing properly when we want to.

[Stephen White, 2012-09-26 14:48:27]

https://codereview.chromium.org/10984023/diff/1002/skia/ext/canvas_paint_win.h
File skia/ext/canvas_paint_win.h (right):

https://codereview.chromium.org/10984023/diff/1002/skia/ext/canvas_paint_win....
skia/ext/canvas_paint_win.h:114: NOTREACHED();
I've never really looked at NOTREACHED() before, but it looks like it does a
DCHECK(false), which only crashes in debug builds AFAIK.  You probably want a
CHECK(false) here instead.

Alternatively, you could do what OnNoMemory does on Windows, which is:

__debugbreak();
_exit(1);

[reed1, 2012-09-26 19:28:04]

On 2012/09/26 14:48:27, Stephen White wrote:
> https://codereview.chromium.org/10984023/diff/1002/skia/ext/canvas_paint_win.h
> File skia/ext/canvas_paint_win.h (right):
> 
>
https://codereview.chromium.org/10984023/diff/1002/skia/ext/canvas_paint_win....
> skia/ext/canvas_paint_win.h:114: NOTREACHED();
> I've never really looked at NOTREACHED() before, but it looks like it does a
> DCHECK(false), which only crashes in debug builds AFAIK.  You probably want a
> CHECK(false) here instead.
> 
> Alternatively, you could do what OnNoMemory does on Windows, which is:
> 
> __debugbreak();
> _exit(1);

Done

[Stephen White, 2012-09-26 19:34:55]

LGTM