Issue 10984017: Remove unnecessary calls to .get() in navigation_entry_impl_unittest.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10984017: Remove unnecessary calls to .get() in navigation_entry_impl_unittest.cc (Closed)

Created:
8 years, 3 months ago by akalin

Modified:
8 years, 2 months ago

Reviewers:
sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unnecessary calls to .get() in navigation_entry_impl_unittest.cc It's more readable to rely on operator->() for smart pointers. BUG=128449 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158637

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -81 lines)			Patch
	M	content/browser/web_contents/navigation_entry_impl_unittest.cc	View		3 chunks	+81 lines, -81 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10984017/1

8 years, 2 months ago (2012-09-25 18:29:54 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...

8 years, 2 months ago (2012-09-25 18:55:57 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10984017/1

8 years, 2 months ago (2012-09-25 19:14:31 UTC) #5

commit-bot: I haz the power

8 years, 2 months ago (2012-09-25 19:22:28 UTC) #6

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages