Issue 3968. Report error if cycle in redirecting factory constructors

compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 package com.google.dart.compiler.type;
 
 import com.google.common.base.Joiner;
 import com.google.common.collect.Iterables;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
 import com.google.common.collect.Sets;
@@ skipping 4776 matching lines @@
       Type type = typeNode.getType();
       assertSame(typeA, type);
       // .named
       DartIdentifier nameNode = findNode(DartIdentifier.class, "named;");
       NodeElement nameElement = nameNode.getElement();
       assertNotNull(nameElement);
       assertSame(elementA.lookupConstructor("named"), nameElement);
     }
   }
   
+  public void test_redirectingFactoryConstructor_cycle() throws Exception {
+    AnalyzeLibraryResult libraryResult = analyzeLibrary(makeCode(
+        "// filler filler filler filler filler filler filler filler filler filler",
+        "class A {",
+        "  factory A.nameA() = C.nameC;",
+        "}",
+        "class B {",
+        "  factory B.nameB() = A.nameA;",
+        "}",
+        "class C {",
+        "  factory C.nameC() = B.nameB;",
+        "}",
+        ""));
+    assertErrors(
+        libraryResult.getErrors(),
+        errEx(ResolverErrorCode.REDIRECTION_CONSTRUCTOR_CYCLE, 3, 11, 7),
+        errEx(ResolverErrorCode.REDIRECTION_CONSTRUCTOR_CYCLE, 6, 11, 7),
+        errEx(ResolverErrorCode.REDIRECTION_CONSTRUCTOR_CYCLE, 9, 11, 7));
+  }
+  
   public void test_redirectingFactoryConstructor_notConst_fromConst() throws Exception {
     AnalyzeLibraryResult libraryResult = analyzeLibrary(makeCode(
         "// filler filler filler filler filler filler filler filler filler filler",
         "class A {",
         "  A.named() {}",
         "}",
         "",
         "class B {",
         "  const factory B.bar() = A.named;",
         "}",
@@ skipping 507 matching lines @@
             && index < sourceInfo.getEnd()
             && clazz.isInstance(node)) {
           result.set((T) node);
         }
         return super.visitNode(node);
       }
     });
     return result.get();
   }
 }