Issue 3968. Report error if cycle in redirecting factory constructors

compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 package com.google.dart.compiler.resolver;
 
 import com.google.dart.compiler.ErrorCode;
 import com.google.dart.compiler.ErrorSeverity;
 import com.google.dart.compiler.SubSystem;
 
 /**
@@ skipping 167 matching lines @@
       "Parameter initializer cannot be use to initialize a static field '%s'"),
   // TODO(zundel): error message needs JUnit test (reachable code?)
   PARAMETER_INIT_WITH_REDIR_CONSTRUCTOR(
       "Parameter initializers cannot be used with redirected constructors"),
   // TODO(zundel): error message needs JUnit test
   PARAMETER_NOT_MATCH_FIELD("Could not match parameter initializer '%s' with any field"),
   REDIRECTION_CONSTRUCTOR_TARGET_TYPE(
       "Target of redirecting factory constructor is not a type"),
   REDIRECTION_CONSTRUCTOR_TARGET_MUST_BE_CONST(
       "Target of constant redirecting factory constructor also should be constant"),
+  REDIRECTION_CONSTRUCTOR_CYCLE("Cycle in redirecting constructors"),
   RETHROW_NOT_IN_CATCH("Re-throw not in a catch block"),
   STATIC_FINAL_REQUIRES_VALUE("Static final fields must have an initial value"),
   STATIC_METHOD_MUST_HAVE_BODY("Static method must have a body"),
   SUPER_IN_FACTORY_CONSTRUCTOR("Cannot use 'super' in a factory constructor"),
   SUPER_IN_STATIC_METHOD("Cannot use 'super' in a static method"),
   SUPER_OUTSIDE_OF_METHOD("Cannot use 'super' outside of a method"),
   SUPER_ON_TOP_LEVEL("Cannot use 'super' in a top-level element"),
   SWITCH_CASE_FALL_THROUGH(ErrorSeverity.WARNING, "Switch case should end with break, continue, return or throw"),
   THIS_IN_STATIC_METHOD("Cannot use 'this' in a static method"),
   THIS_IN_INITIALIZER_AS_EXPRESSION("Cannot reference 'this' as expression in initializer list"),
@@ skipping 44 matching lines @@
   @Override
   public SubSystem getSubSystem() {
     return SubSystem.RESOLVER;
   }
 
   @Override
   public boolean needsRecompilation() {
     return true;
   }
 }